Skip to content

Commit

Permalink
chore: drop node 4 EOL, add node 10 🎉 (#1556)
Browse files Browse the repository at this point in the history
Node 4 you were the beginning of a golden age of node. I loved you and will miss you.
  • Loading branch information
reconbot authored Apr 28, 2018
1 parent 131a939 commit e1998b3
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 40 deletions.
18 changes: 5 additions & 13 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,24 +19,24 @@ env:
global:
- secure: "L+AGMJc5NAsuym+xzB4FWj0c2rCobosixkoxLBhDBVkLiYsMtfS9y1w8Xz0pbWKJnJAH9tfwHluu5aX2qYk2HbreSyNzy8hbPW+9RbSyAQexeiZG4mLuDEz0xvlpCCQBsS1OfMypQk0/JvL4oA9B/xasrpkeVuPI7dwAz2WcFms="
matrix:
- TRAVIS_NODE_VERSION="4"
- TRAVIS_NODE_VERSION="4" ARCH="x86"
- TRAVIS_NODE_VERSION="6"
- TRAVIS_NODE_VERSION="6" ARCH="x86"
- BINARY_BUILDER="true" TRAVIS_NODE_VERSION="8"
- BINARY_BUILDER="true" TRAVIS_NODE_VERSION="8" ARCH="x86"
- TRAVIS_NODE_VERSION="9"
- TRAVIS_NODE_VERSION="9" ARCH="x86"
- TRAVIS_NODE_VERSION="10"
- TRAVIS_NODE_VERSION="10" ARCH="x86"
matrix:
exclude:
- os: osx
env: TRAVIS_NODE_VERSION="4" ARCH="x86"
- os: osx
env: TRAVIS_NODE_VERSION="6" ARCH="x86"
- os: osx
env: BINARY_BUILDER="true" TRAVIS_NODE_VERSION="8" ARCH="x86"
- os: osx
env: TRAVIS_NODE_VERSION="9" ARCH="x86"
- os: osx
env: TRAVIS_NODE_VERSION="10" ARCH="x86"

before_install:

Expand All @@ -57,9 +57,6 @@ before_install:
- if [[ $TRAVIS_OS_NAME == "linux" ]]; then export CXX=g++-4.8; fi
- $CXX --version

# upgrade npm if on node 4 as npm2 doesn't like our dev peer deps
- if [[ $TRAVIS_NODE_VERSION == "4" ]]; then npm install -g npm; fi

# Cleanup the output of npm
- npm config set progress false
- npm config set spin false
Expand Down Expand Up @@ -89,12 +86,7 @@ install:
- npm install --build-from-source

script:
# linting no longer works on node 4
- >
if [[ $TRAVIS_NODE_VERSION != "4" ]]; then
npm run lint
fi;
- npm run lint
- node ./
- npm test

Expand Down
24 changes: 12 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,18 +83,18 @@ In addition to reading the [article mentioned above](http://www.voodootikigod.co
### Platform Support
`serialport` supports NodeJS v4 and upwards. For versions 0.10 and 0.12, use `serialport@4`. The platforms, architectures and Node versions that `serialport` supports are the following;

| Platform / Arch | Node v4.x | Node v6.x | Node v8.x | Node v9.x |
| --- | --- | --- | --- | --- |
| Linux / ia32 |||||
| Linux / x64 |||||
| Linux / ARM v6¹ |||||
| Linux / ARM v7¹ |||||
| Linux / ARM v8¹ |||||
| Linux / MIPSel¹ |||||
| Linux / PPC64¹ |||||
| Windows² / x86 |||||
| Windows² / x64 |||||
| OSX³ / x64 |||||
| Platform / Arch | Node v4.x | Node v6.x | Node v8.x | Node v9.x | Node v10.x |
| --- | --- | --- | --- | --- | --- |
| Linux / ia32 ||||||
| Linux / x64 ||||||
| Linux / ARM v6¹ ||||||
| Linux / ARM v7¹ ||||||
| Linux / ARM v8¹ ||||||
| Linux / MIPSel¹ ||||||
| Linux / PPC64¹ ||||||
| Windows² / x86 ||||||
| Windows² / x64 ||||||
| OSX³ / x64 ||||||

¹ ARM, MIPSel and PPC64¹ platforms are not currently part of our testing or build matrix, but are known to work.

Expand Down
17 changes: 2 additions & 15 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,30 +6,19 @@ environment:
secure: iDcAJCYgJK4tffyzEHbMVR8DatJcIN8eY0h29p9JQkl43TcEcm6Z6JLOBpGDk1MJ

matrix:
- nodejs_version: "4"
- nodejs_version: "6"
- binary_builder: "true"
nodejs_version: "8"
- nodejs_version: "9"
- nodejs_version: "10"

platform:
- x86
- x64

# Dropping support for node 4 on 32 windows because it has isuses with ssl certs and npm
matrix:
exclude:
- platform: x86
nodejs_version: "4"


install:
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:platform;
# upgrade npm if on node 4 as npm2 doesn't like our dev peer deps
- ps: >
if ($env:nodejs_version -eq "4") {
npm install -g npm | Write-Host;
}
npm config set progress false
npm config set spin false
Expand Down Expand Up @@ -66,9 +55,7 @@ build_script:

test_script:
- ps: >
if ($env:nodejs_version -ne "4") {
npm run lint
}
npm run lint
node ./
# If we run npm test in powershell it'll have the wrong encoding so we have to do it like this
Expand Down

0 comments on commit e1998b3

Please sign in to comment.