Update Types for new unstable_RouterContextProvider for [email protected] #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's holding this one from merge? |
Owner
|
I just did this along other changes in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey, React Router 7.8.0 changed type definitions for Contexts from just
unstable_RouterContextProvidertoReadonly<unstable_RouterContextProvider>. So Typescript yells at me now using wrong contexts for my session middleware in my app loaders.See https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#unstable-changes and remix-run/react-router#14097
I am not sure if pinning version to 7.8.0 is really wanted/needed. But as I was exploring the Repo i thought, why not submit these changes. Lets hope this will help :)