chore(deps-dev): bump eslint from 9.39.2 to 10.0.0#269
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 95.99% 95.99%
=======================================
Files 91 91
Lines 13504 13504
Branches 1242 1242
=======================================
Hits 12963 12963
Misses 541 541 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s linting toolchain by upgrading ESLint to v10 and adding an override intended to keep eslint-plugin-react compatible while upstream issues are addressed.
Changes:
- Bump
eslintfrom^9to^10.0.0 - Add an
overridesentry to forceeslint-plugin-reactto a fork/branch - Regenerate
package-lock.jsonto reflect the new dependency graph
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Upgrades ESLint to v10 and adds an override for eslint-plugin-react. |
| package-lock.json | Updates the resolved ESLint version and records the overridden eslint-plugin-react source plus transitive changes. |
| "overrides": { | ||
| "eslint-plugin-react": "github:ledsun/eslint-plugin-react#update-deprecated-calls-v8" | ||
| }, |
There was a problem hiding this comment.
The override uses the github: shorthand, which npm resolves to git+ssh://git@github.com/... (see package-lock). This will break npm ci/installs in environments without GitHub SSH keys (e.g., CI). Prefer a git+https://github.com/... URL (or https://...) for the override so it can be fetched anonymously.
| "bill-management" | ||
| ], | ||
| "overrides": { | ||
| "eslint-plugin-react": "github:ledsun/eslint-plugin-react#update-deprecated-calls-v8" |
There was a problem hiding this comment.
The override points to a mutable branch (#update-deprecated-calls-v8). Even with a lockfile, a future npm install can silently change the resolved commit when the branch moves. Consider pinning the override to an immutable commit SHA (or a tag) to keep dependency resolution reproducible.
| "eslint-plugin-react": "github:ledsun/eslint-plugin-react#update-deprecated-calls-v8" | |
| "eslint-plugin-react": "github:ledsun/eslint-plugin-react#<pinned-commit-sha>" |
🎯 Scope & Context
Type: Chore
Intent: Bump eslint from 9.39.2 to 10.0.0
Related Issues:
🧭 Reviewer Guide
Complexity: Low
Entry Point
No specific entry point needed - changes are straightforward and self-contained.
Sensitive Areas
package.json: Bump eslint. Use @ledsun fork.