Raise ImportError if CDLL of openmp library fails #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Ping @serge-sans-paille, this is blocking the osx-arm builds for scipy in conda-forge, see conda-forge/scipy-feedstock#183 |
|
@h-vetinari sorry for the delay. If I understand correctly, one may end up finding libgomp but for the wrong arch, right? |
omp/__init__.py
Outdated
| try: | ||
| self.libomp = ctypes.CDLL(libgomp_path) | ||
| except OSError: | ||
| raise ImportError("I couldn't load the openmp library found." |
There was a problem hiding this comment.
Maybe be more specific in the message, something like "found openMP library '{}' but couldn't load it. This may happen..."
|
Sorry for the delay and thanks for the quick update o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for conda-forge/scipy-feedstock where we are cross compiling for osx-arm64.