Update invite models#3552
Merged
Merged
Conversation
Contributor
Author
|
Reverted the nightly pins and moved the Clippy fixes to a separate PR. |
meditationmind
force-pushed
the
update-invite-models
branch
from
May 13, 2026 20:08
811c5f4 to
6a93100
Compare
arqunis
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates invite-related models and endpoints to match the current API.
Fixes #3402.
The previous
RichInvite(nowInviteMetadata) essentially functioned as a different kind of invite, rather than the extension ofInvitethat it's meant to be, and this resulted in a deserialization error since the same endpoint could return two different types depending on permissions.This PR fixes the issue by consolidating all invites as
Inviteand extending that withInviteMetadata. Many other discrepancies with the API have been patched up in the process. Also fixed a deserialization error related to including an embedded app target, which was likely simply never tested or encountered.role_idshas been added to the channel invite builder, to allow for assigning roles when an invite is accepted. I tested all of the above, as well as invites with scheduled event IDs, getting invite info while banned, group DM invites, and several other combinations.I did not add the new target users endpoints.
This PR also pins nightly to 2026-05-05 in the Clippy and Docs workflows to address rust #156264. I'll revert these pins once #156284 is merged.nightly pins reverted.