Skip to content

Fix shard runner info #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

Fix shard runner info #3345

merged 1 commit into from
Apr 17, 2025

Conversation

@GnomedDev
Copy link
Member

@GnomedDev GnomedDev commented Apr 14, 2025

Previously, example 7 didn't work as runner_info would clone the hashmap before it had any entries. This solution goes back to how ShardManager::runners is in current, except using DashMap and try_get_mut.

@github-actions github-actions bot added gateway Related to the `gateway` module. examples Related to Serenity's examples. labels Apr 14, 2025
mkrasnitski
mkrasnitski reviewed Apr 14, 2025
View reviewed changes
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users dependencies Related to Serenity dependencies. and removed dependencies Related to Serenity dependencies. labels Apr 17, 2025
@GnomedDev GnomedDev merged commit c056feb into serenity-rs:next Apr 17, 2025
24 checks passed
@GnomedDev GnomedDev deleted the fix-shard-runners branch April 17, 2025 16:28
@tazz4843 tazz4843 mentioned this pull request Apr 20, 2025
Merged
GnomedDev added a commit that referenced this pull request Apr 28, 2025
@GnomedDev
Fix shard runner info (#3345)
e93d457
GnomedDev added a commit that referenced this pull request May 19, 2025
@GnomedDev
Fix shard runner info (#3345)
0c37bf4
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jun 30, 2025
@GnomedDev @mkrasnitski
Fix shard runner info (serenity-rs#3345)
ee486e8
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jun 30, 2025
@GnomedDev @mkrasnitski
Fix shard runner info (serenity-rs#3345)
ab61fee
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jun 30, 2025
@GnomedDev @mkrasnitski
Fix shard runner info (serenity-rs#3345)
ad1c3bb
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 28, 2025
@GnomedDev @mkrasnitski
Fix shard runner info (serenity-rs#3345)
3e3f4c2
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 28, 2025
@GnomedDev @mkrasnitski
Fix shard runner info (serenity-rs#3345)
abb5c30
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
@GnomedDev @mkrasnitski
Fix shard runner info (serenity-rs#3345)
99a3974
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
@GnomedDev @mkrasnitski
Fix shard runner info (serenity-rs#3345)
7a69306
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
@GnomedDev @mkrasnitski
Fix shard runner info (serenity-rs#3345)
4443bca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arqunis arqunis arqunis approved these changes

@mkrasnitski mkrasnitski mkrasnitski approved these changes

+1 more reviewer

@tazz4843 tazz4843 tazz4843 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. examples Related to Serenity's examples. gateway Related to the `gateway` module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GnomedDev @arqunis @mkrasnitski @tazz4843