Skip to content

Conversation

@mkrasnitski
Copy link
Collaborator

The macro wasn't defining anything else besides the variants of FullEvent, so we can just use native syntax for that.

@github-actions github-actions bot added the gateway Related to the `gateway` module. label Mar 25, 2025
@DPlayer234
Copy link
Contributor

This is now missing #[cfg_attr(not(feature = "unstable"), non_exhaustive)] on each variant. I believe that was in part the reason why the macro wasn't immediately removed.

@mkrasnitski
Copy link
Collaborator Author

mkrasnitski commented Mar 25, 2025

I see. The attribute was added in #3324 to guard against breakage if a new field is added to a variant, now that event handling matches directly against FullEvent.

@jamesbt365
Copy link
Member

I see. The attribute was added in #3324 to guard against breakage if a new field is added to a variant, now that event handling matches directly against FullEvent.

Yeah its just easier to define it this way in the macro, additionally, they'll be another line too if #3056 gets merged in, probably best to keep the macro instead of just repeating this every time.

@mkrasnitski mkrasnitski closed this Apr 7, 2025
@mkrasnitski mkrasnitski deleted the full-event-macro branch April 17, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gateway Related to the `gateway` module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants