Expose ShardManager::manager_tx field for more flexible control flow
#3310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the channel to be cloned by something other than the `Client`, (e.g. poise or any other framework that gets a client from `Framework::init`), so that messages can be sent directly to the manager. In particular, `ShardManagerMessage::Quit` now holds a `Result` instead of just an error. This enables things like shutdown commands to send `Ok(())` to the manager to cleanly close the connection.
Collaborator
Author
|
Supeseded by #3120. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the channel to be cloned by something other than the
Client, (e.g. poise or any other framework that gets a client fromFramework::init), so that messages can be sent directly to the manager.In particular,
ShardManagerMessage::Quitnow holds aResultinstead of just an error. This enables things like shutdown commands to sendOk(())to the manager to cleanly close the connection.