Fix disconnections on successful gateway resume #3102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only break of out the `ShardRunner` loop if the resume failed and we have to reidentify.
arqunis
approved these changes
Feb 3, 2025
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 14, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 5, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 5, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 7, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 10, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 11, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 26, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 26, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
GnomedDev
pushed a commit
that referenced
this pull request
Apr 28, 2025
A regression introduced by #3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
GnomedDev
pushed a commit
that referenced
this pull request
May 19, 2025
A regression introduced by #3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jun 30, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jun 30, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jun 30, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 28, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 28, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
A regression introduced by serenity-rs#3099 was that successful resumes will break out of the loop inside `ShardRunner::run`, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression introduced by #3099 was that successful resumes will break out of the loop inside
ShardRunner::run, but they shouldn't (or rather, didn't before). Therefore, only break out of the loop if the resume failed and we had to fallback to reidentifying.