Skip to content

Remove _arc methods #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2023
Merged

Remove _arc methods #2654

merged 3 commits into from
Dec 8, 2023

Conversation

@GnomedDev
Copy link
Member

@GnomedDev GnomedDev commented Dec 5, 2023

These are unnecessary, taking impl Into<Arc<T>> allows passing T or Arc<T>.

@github-actions github-actions bot added the client Related to the `client` module. label Dec 5, 2023
arqunis
arqunis requested changes Dec 8, 2023
View reviewed changes
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Dec 8, 2023
@GnomedDev @arqunis
Fix small whoopsie
29925cb 
Co-authored-by: Alex M. M. <[email protected]>
@arqunis arqunis merged commit 6ec83f2 into serenity-rs:next Dec 8, 2023
arqunis pushed a commit to arqunis/serenity that referenced this pull request Dec 28, 2023
@GnomedDev @arqunis
Remove *_arc methods (serenity-rs#2654)
593efcb 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 2, 2024
@GnomedDev @arqunis
Remove *_arc methods (serenity-rs#2654)
c81c0dd 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 5, 2024
@GnomedDev @arqunis
Remove *_arc methods (serenity-rs#2654)
dd9661d 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2024
@GnomedDev @arqunis
Remove *_arc methods (serenity-rs#2654)
0f5f608 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 22, 2024
@GnomedDev @arqunis
Remove *_arc methods (serenity-rs#2654)
7fad87a 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Remove *_arc methods (#2654)
df706ff 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Remove *_arc methods (serenity-rs#2654)
4c6247d 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Remove *_arc methods (#2654)
6a15623 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Remove *_arc methods (#2654)
8ea9d78 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Remove *_arc methods (#2654)
ec2f131 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
bd18de9 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Remove *_arc methods (#2654)
a85b283 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
2a0aafe 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
adf8e8d 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Remove *_arc methods (#2654)
d4e6716 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Remove *_arc methods (#2654)
c5960b1 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Remove *_arc methods (#2654)
84963d7 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Remove *_arc methods (#2654)
08ce162 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
b859810 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
e3f21f6 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
1619aed 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Remove *_arc methods (#2654)
05def38 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Remove *_arc methods (#2654)
7a50147 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Remove *_arc methods (#2654)
e48d344 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
651380e 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Remove *_arc methods (#2654)
48d264a 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
34b8e52 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
d5e01ad 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
e52750e 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Remove *_arc methods (#2654)
30dc997 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
4c44ed0 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
c449f33 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Remove *_arc methods (#2654)
c410df7 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
963808a 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Remove *_arc methods (#2654)
c37c7e1 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
cc1bd45 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
062972b 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Remove *_arc methods (serenity-rs#2654)
c651467 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
0ca5865 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 14, 2025
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
473ee03 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Mar 5, 2025
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
cd5ae6f 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Mar 5, 2025
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
fd9dafd 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Mar 7, 2025
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
b8d1e28 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Mar 10, 2025
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
724009d 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Mar 11, 2025
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
434f546 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 26, 2025
@GnomedDev
Remove *_arc methods (serenity-rs#2654)
64ca545 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request Apr 28, 2025
@GnomedDev
Remove *_arc methods (#2654)
a128437 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
GnomedDev added a commit that referenced this pull request May 19, 2025
@GnomedDev
Remove *_arc methods (#2654)
2fec3f0 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jun 30, 2025
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
d0e0076 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 28, 2025
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
e75a807 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
@GnomedDev @mkrasnitski
Remove *_arc methods (serenity-rs#2654)
c9514b4 
These are unnecessary. Accepting `impl Into<Arc<T>>` allows passing either `T` or `Arc<T>`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arqunis arqunis arqunis approved these changes

Assignees

No one assigned

Labels

breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users client Related to the `client` module. enhancement An improvement to Serenity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GnomedDev @arqunis