Skip to content

Fix README.md minor error #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2023
Merged

Fix README.md minor error #2620

merged 2 commits into from
Nov 26, 2023

Conversation

@LaytonGB
Copy link
Contributor

@LaytonGB LaytonGB commented Nov 24, 2023

FIX: bad example was re-using the moved framework value

Before and after screenshots of problem and solution

Before

image

After

image

@LaytonGB
Update README.md
58398e4 
FIX: bad example was re-using the moved `framework` value
mkrasnitski
mkrasnitski requested changes Nov 25, 2023
View reviewed changes
@mkrasnitski
Copy link
Collaborator

mkrasnitski commented Nov 26, 2023

Actually, as it turns out, in v0.12, since the standard framework is configurable at runtime, the configure function no longer consumes self. Therefore, the example can mostly go unchanged (sans the change to the call to configure).

@arqunis arqunis added the fix A solution to an existing bug. label Nov 26, 2023
@arqunis arqunis merged commit 3bd2e4e into serenity-rs:current Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkrasnitski mkrasnitski mkrasnitski approved these changes

Assignees

No one assigned

Labels

fix A solution to an existing bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LaytonGB @mkrasnitski @arqunis