Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MSRV to Rust 1.70 #2455

Merged
merged 2 commits into from
Jun 3, 2023
Merged

Bump MSRV to Rust 1.70 #2455

merged 2 commits into from
Jun 3, 2023

Conversation

mkrasnitski
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the ci Related to the continuous integration. label Jun 2, 2023
@mkrasnitski
Copy link
Collaborator Author

Hmm, clippy is failing, but I think it's actually a false positive, because the variables are used inside of quote!. Removing the clones causes compilation to fail. Is this something that should be reported? @acdenisSK @kangalio

@kangalio
Copy link
Collaborator

kangalio commented Jun 2, 2023

Sure, doesn't hurt to report

@mkrasnitski
Copy link
Collaborator Author

Already reported in rust-lang/rust-clippy#10545

@github-actions github-actions bot added the command_attr Related to the `command_attr` crate. label Jun 2, 2023
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Jun 3, 2023
@arqunis arqunis merged commit d3dab34 into serenity-rs:next Jun 3, 2023
@mkrasnitski mkrasnitski deleted the msrv branch June 3, 2023 22:05
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@mkrasnitski
Bump MSRV to Rust 1.70 (serenity-rs#2455)
54f43db
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@mkrasnitski
Bump MSRV to Rust 1.70 (serenity-rs#2455)
d616b75
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@mkrasnitski
Bump MSRV to Rust 1.70 (serenity-rs#2455)
bb6b7d9
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@mkrasnitski @arqunis
Bump MSRV to Rust 1.70 (serenity-rs#2455)
4797d06
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@mkrasnitski @arqunis
Bump MSRV to Rust 1.70 (serenity-rs#2455)
2ea156d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users ci Related to the continuous integration. command_attr Related to the `command_attr` crate. enhancement An improvement to Serenity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkrasnitski @kangalio @arqunis