Skip to content

Conversation

@cclauss
Copy link

@cclauss cclauss commented Nov 15, 2025

Updated Node.js versions in CI matrix and added Linux-specific dependencies.
Updated Node.js versions in CI matrix and commented out test runs.
Added libxtst-dev to the installation step and commented out the state.js test.
Add installation of node-addon-api in CI workflow
Exclude the latest Node.js version on Ubuntu from the CI matrix.
Removed installation of node-addon-api from CI workflow.
@s-h-a-d-o-w
Copy link
Contributor

s-h-a-d-o-w commented Nov 15, 2025

This package is actually unmaintained (I'm not a maintainer), although I will fork it if it becomes absolutely necessary.

That said - I'm not 100% sure that I understand the intention of this. In the title, you say running yarn test but the action only runs yarn.
I'm assuming that you're trying to ensure that this project builds correctly, since yarn will trigger node-gyp? Given that it does build correctly with VS community, as mentioned here, and this action passes on your account anyway, I currently don't have concerns about this.

@cclauss
Copy link
Author

cclauss commented Nov 16, 2025

trying to ensure that this project builds correctly

% yarn test fails, so it is commented out.

@cclauss cclauss changed the title GitHub Action to run yarn test GitHub Action to ensure this project builds successfully Nov 16, 2025
@s-h-a-d-o-w
Copy link
Contributor

Got it. I appreciate you wanting to improve reliability in this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants