Mark generated impl de::Visitor
blocks as #[automatically_derived]
#2866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
cargo llvm-cov
on one of my projects I noticed that the#[derive(Deserialize)]
annotations on my structs were marked as not covered.This PR adds
#[automatically_derived]
also to theimpl de::Visitor
blocks that are generated. In my tests, they now no longer show up in the coverage as not covered.rustc
automatically excludesimpl
blocks marked with#[automatically_derived]
since rust-lang/rust#120185.The generated
impl Deserialize
block is already marked with#[automatically_derived]
and thus correctly not counted.However, the visitors and field visitors which are generated within the
deserialize
method were counted towards the coverage.