Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code for generation of struct deserializers #2444

Merged
merged 10 commits into from
Jul 6, 2023
Merged

Simplify code for generation of struct deserializers #2444

merged 10 commits into from
Jul 6, 2023

Commits on Jun 26, 2023

  1. Generate visit_seq only when needed

    @Mingun
    Mingun committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    7952619 View commit details
    Browse the repository at this point in the history

  2. Reorder variables to match order in final quote!

    @Mingun
    Mingun committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    95730dc View commit details
    Browse the repository at this point in the history

  3. Pull up call to deserialize_map because it's identical

    @Mingun
    Mingun committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    2796833 View commit details
    Browse the repository at this point in the history

  4. Inline deserialize_struct_as_map_visitor and `deserialize_struct_as… 

    …_struct_visitor`
    @Mingun
    Mingun committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    75db730 View commit details
    Browse the repository at this point in the history

  5. Actually, field_names_idents can be calculated using the same code … 

    …in both cases

When !cattrs.has_flatten() all fields is !field.attrs.flatten()

Co-authored-by: Oliver Schneider <[email protected]>
    @Mingun @oli-obk
    Mingun and oli-obk committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    5ffebeb View commit details
    Browse the repository at this point in the history

  6. Simplify check for missing fields

    @Mingun
    Mingun committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    fb3a9e0 View commit details
    Browse the repository at this point in the history

  7. Move deserialize_generated_identifier out from if because the call … 

    …is same in both arms
    @Mingun
    Mingun committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    bbbd1d2 View commit details
    Browse the repository at this point in the history

  8. Replace enum with boolean parameter

    @Mingun
    Mingun committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    d0dfc45 View commit details
    Browse the repository at this point in the history

  9. Replace several linked variables with enumeration for structs

    @Mingun
    Mingun committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    ee7d77d View commit details
    Browse the repository at this point in the history

  10. Replace several linked variables with enumeration for tuples

    @Mingun
    Mingun committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    4cf1fec View commit details
    Browse the repository at this point in the history