Add alias_all attribute for containers similar to rename_all #1972
Conversation
|
|
||
| // Parse `#[serde(alias_all = "foo")]` | ||
| Meta(NameValue(m)) if m.path == ALIAS_ALL => { | ||
| if let Ok(s) = get_lit_str(cx, ALIAS_ALL, &m.lit) { |
There was a problem hiding this comment.
PascalCase and camelCase differs only by the first character, maybe we can have an optimization to not check all the characters twice?
There was a problem hiding this comment.
I am not sure to understand, the renaming is done somewhere else and is not impacted by this change. I think this optimization is not needed and would be hard to implement given current implementation.
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
Thanks for the PR! I am closing because I would prefer not to build this new attribute into serde_derive. Over time since 1.0 I have tried to be increasingly selective about adding more attributes, approaching a moratorium on new attributes, to prevent the list from expanding forever and destroying compile times, and to curb the superlinear complexity of attributes interacting with each other. I think this one is just too uncommonly applicable to make sense adding right now.
|
@dtolnay Given, that #1530 and this PR received exclusively positive feedback (there's even a |
4 participants
Closes #1530.