Skip to content

Commit

Permalink
Touch up PR 2567
Browse files Browse the repository at this point in the history
  • Loading branch information
dtolnay committed Aug 11, 2024
1 parent 84c7419 commit e52b7b3
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
4 changes: 2 additions & 2 deletions serde_derive/src/de.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1268,7 +1268,7 @@ fn prepare_enum_variant_enum(variants: &[Variant]) -> (TokenStream, Stmts) {

let variant_visitor = Stmts(deserialize_generated_identifier(
&variant_names_idents,
false, // variant identifiers does not depend on the presence of flatten fields
false, // variant identifiers do not depend on the presence of flatten fields
true,
None,
fallthrough,
Expand Down Expand Up @@ -2708,7 +2708,7 @@ fn deserialize_map_in_place(
) -> Fragment {
assert!(
!cattrs.has_flatten(),
"inplace deserialization of maps doesn't support flatten fields"
"inplace deserialization of maps does not support flatten fields"
);

// Create the field names for the fields.
Expand Down
10 changes: 5 additions & 5 deletions serde_derive/src/internals/attr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@ pub struct Container {
type_into: Option<syn::Type>,
remote: Option<syn::Path>,
identifier: Identifier,
/// `true` if container is a `struct` and it has a field with `#[serde(flatten)]`
/// attribute or it is an `enum` with a struct variant which has a field with
/// `#[serde(flatten)]` attribute. Examples:
/// True if container is a struct and has a field with `#[serde(flatten)]`,
/// or is an enum with a struct variant which has a field with
/// `#[serde(flatten)]`.
///
/// ```ignore
/// struct Container {
Expand Down Expand Up @@ -810,8 +810,8 @@ pub struct Variant {
rename_all_rules: RenameAllRules,
ser_bound: Option<Vec<syn::WherePredicate>>,
de_bound: Option<Vec<syn::WherePredicate>>,
/// `true` if variant is a struct variant which contains a field with `#[serde(flatten)]`
/// attribute. Examples:
/// True if variant is a struct variant which contains a field with
/// `#[serde(flatten)]`.
///
/// ```ignore
/// enum Enum {
Expand Down
1 change: 1 addition & 0 deletions test_suite/tests/regression/issue1904.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#![allow(dead_code)] // we do not read enum fields

use serde_derive::Deserialize;

#[derive(Deserialize)]
Expand Down
2 changes: 2 additions & 0 deletions test_suite/tests/regression/issue2792.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#![allow(dead_code)] // we do not read enum fields

use serde_derive::Deserialize;

#[derive(Deserialize)]
Expand All @@ -12,5 +13,6 @@ pub enum A {
e: E,
},
}

#[derive(Deserialize)]
pub struct E {}

0 comments on commit e52b7b3

Please sign in to comment.