distinct option for count #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is already implemented in 2.0 - not sure if it's gonna help with the issues mentioned though ... Do you mind fixing the indentation? |
|
Yeah, I know that it's in 2.0 but I still need to use 1.7 here and I thought this might be better than build the queries raw. Sorry about the indentation. |
|
Merged, thanks :) |
|
I put comment in issue #1953 but it goes here. @mickhansen do you need some help with docs? Best. |
IrfanBaqui
pushed a commit
to IrfanBaqui/sequelize
that referenced
this pull request
Jun 24, 2015
distinct option for count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
not sure that you want it but atm the count (or findAndCountAll) is not really working if you include something.
Now you can use an distinct parameter which fixes that for most cases.
Might helps with #1953 and #1517 too.
Let me know what you think.