Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: typescript migration #111

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

refactor: typescript migration #111

wants to merge 6 commits into from

Commits on Mar 10, 2021

  1. basic typescript migration

    @Keimeno
    Keimeno committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    ad3d13a View commit details
    Browse the repository at this point in the history

  2. rewritten model definition with ModelDefined type

    @Keimeno
    Keimeno committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    b7885c8 View commit details
    Browse the repository at this point in the history

  3. run typescript on strict mode

    @Keimeno
    Keimeno committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    cd6720c View commit details
    Browse the repository at this point in the history

  4. added explanation on why id is omitted 

    also added an explanation on why the orchestraId field must be defined in the interface, although we don't explicitly define it
    @Keimeno
    Keimeno committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    aaa26a4 View commit details
    Browse the repository at this point in the history

  5. added documentation on import order

    @Keimeno
    Keimeno committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    dc94484 View commit details
    Browse the repository at this point in the history

  6. make id field optional, instead of omitting it

    @Keimeno
    Keimeno committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    38752e7 View commit details
    Browse the repository at this point in the history