use CompletableFuture instead Future to listen progress in the task #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pditommaso
reviewed
Aug 16, 2022
src/main/groovy/io/seqera/wave/service/builder/ContainerBuildServiceImpl.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
|
Ok, I went further with the idea of just using the build result completable future. I've also improved a bit the error reporting when the build fails returning the build error message. There's something to fix with the CostomImageControllerTest but cannot figure out what's the problem. Please give it look |
Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso
force-pushed
the
79-improve-image-build-waiting-mechanism-1
branch
from
7a6fcfa
to
c4900c1
Compare
Fixed. if the image was not requested previously the ContainerService will return null and StorageService and empty Optional |
|
Nice! very neat this implementation 🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #79