Check block existence with object operation #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Di Tommaso <[email protected]>
|
@munishchouhan can you give it a try at your convenience. Tagging @gavinelder for visibility. |
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
sure |
|
Tested in Local, pods are resulting in Error, Digging further to find the cause |
|
There is a problem with my colima setup using other option to test it |
|
Tested locally |
|
cache: |
|
tested blob exists: |
munishchouhan
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the logic for checking the existence of blob cache by using S3 operation instead of HTTP head method.
This is needed to prevent that the result of the HTTP HEAD check for a non-existing object retuning 404 (not found) is cached by the underlying caching rule as documented here.
The of S3 API should bypass the caching layer and therefore preventing this issue.