-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Conda lockfile rendering in build view #727
Merged
pditommaso
merged 16 commits into
master
from
721-conda-lock-file-may-not-be-rendered-correctly
Dec 15, 2024
Merged
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
aa278b2
fixed conda file rendering
munishchouhan 22a5af7
fix lockfile download
munishchouhan a646969
Merge branch 'master' into 721-conda-lock-file-may-not-be-rendered-co…
munishchouhan 7490150
formatted [ci skip]
munishchouhan 0cd4302
Merge branch 'master' into 721-conda-lock-file-may-not-be-rendered-co…
munishchouhan 5caf026
Merge branch 'master' into 721-conda-lock-file-may-not-be-rendered-co…
munishchouhan ac959ec
added comment
munishchouhan a6d4a92
added another check
munishchouhan c201b25
minor change [ci skip]
munishchouhan 17bd6f8
Merge branch 'master' into 721-conda-lock-file-may-not-be-rendered-co…
munishchouhan 04f5acb
moved logic to storeCondaLock
munishchouhan eef1629
fixed logic
munishchouhan d0237cb
refactored and added tests
munishchouhan 435e277
Merge branch 'master' into 721-conda-lock-file-may-not-be-rendered-co…
munishchouhan ef9929b
Merge branch 'master' into 721-conda-lock-file-may-not-be-rendered-co…
pditommaso 9eb59a7
Improve logging
pditommaso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's isolate this logic into a separate method, so it can be tested independently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done