-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SSL and AUTH for redis #717
Support SSL and AUTH for redis #717
Conversation
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Tested locally with ssl and auth and its working successfully |
so after digging i found that, jedispool is working with ssl and auth, error is coming from SpillwayRateLimiter
|
Signed-off-by: munishchouhan <[email protected]>
solved it by injecting the JedisPool in SpillWayStorageFactory |
Tested successfully with local redis and elasticcache redis with ssl and auth |
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Can be tested one more time, and merge? |
ok sure |
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Tested successfully in Dev with 10 builds and transfers |
src/main/groovy/io/seqera/wave/ratelimit/impl/SpillWayStorageFactory.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: munishchouhan <[email protected]>
@munishchouhan ok, let's update the |
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
done |
Signed-off-by: munishchouhan <[email protected]>
This PR will add: