Add scan failure duration setting

[pditommaso]

This PR adds Scan failure duration setting

[pditommaso]

@munishchouhan quick double check on this ?

[munishchouhan]

@munishchouhan quick double check on this ?

ok sure

[munishchouhan]

@pditommaso in case of build and mirror docker client retries, but how will this help in case of scan?
because there won't be a retry in this case.

[pditommaso]

Yeah, just realised the same.

[pditommaso]

Let me try one thing

[munishchouhan]

i tried like this

(base) munish.chouhan@Munishs-MacBook-Pro wavedevmemeoryissue % docker pull $(wave --conda-package bwa  --wave-endpoint http://localhost:9090 --platform linux/arm64 --scan-mode required --await)
Container provisioning did not complete successfully
- Reason: Container security scan did not complete successfully
- Find out more here: https://wave.eu.ngrok.io/view/scans/sc-4f9a5dbaddc1b1c4_1

What's next:
    View a summary of image vulnerabilities and recommendations → docker scout quickview 
"docker pull" requires exactly 1 argument.
See 'docker pull --help'.

Usage:  docker pull [OPTIONS] NAME[:TAG|@DIGEST]

Download an image from a registry

[pditommaso]

Think it's needed to delete the scanId when there's a failure, otherwise it will continue to use the same. Please give a try the last push

[munishchouhan]

so where does the retry will happen in this case, i sent the request twice, still same:

(base) munish.chouhan@Munishs-MacBook-Pro wavedevmemeoryissue % docker pull $(wave --conda-package bwa  --wave-endpoint http://localhost:9090 --platform linux/arm64 --scan-mode required --await)
Container provisioning did not complete successfully
- Reason: Container security scan did not complete successfully
- Find out more here: https://wave.eu.ngrok.io/view/scans/sc-4f9a5dbaddc1b1c4_1

What's next:
    View a summary of image vulnerabilities and recommendations → docker scout quickview 
"docker pull" requires exactly 1 argument.
See 'docker pull --help'.

Usage:  docker pull [OPTIONS] NAME[:TAG|@DIGEST]

Download an image from a registry
(base) munish.chouhan@Munishs-MacBook-Pro wavedevmemeoryissue % docker pull $(wave --conda-package bwa  --wave-endpoint http://localhost:9090 --platform linux/arm64 --scan-mode required --await)
Container provisioning did not complete successfully
- Reason: Container security scan did not complete successfully
- Find out more here: https://wave.eu.ngrok.io/view/scans/sc-4f9a5dbaddc1b1c4_1

What's next:
    View a summary of image vulnerabilities and recommendations → docker scout quickview 
"docker pull" requires exactly 1 argument.
See 'docker pull --help'.

Usage:  docker pull [OPTIONS] NAME[:TAG|@DIGEST]

Download an image from a registry

[pditommaso]

It's not a retry, the scanId in the store should be deleted, so once there's a new request a new one is assigned e.g. xxx_1 -> xxx_2

[munishchouhan]

one thing i notice, even if i select --scan-mode required. log is printing:
DEBUG i.s.w.controller.ContainerController - New container request fulfilled

[munishchouhan]

and scan is not triggering after failure also, i am setting failure duration to 10s:

[pditommaso]

The problem was solved by this 239fffd