Skip to content

fixed exception when there is no conda lockfile #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 11, 2024

Conversation

munishchouhan
Copy link
Member

This pr will fix the exception, when there is no conda file in logs

Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
@munishchouhan munishchouhan linked an issue Oct 10, 2024 that may be closed by this pull request
munishchouhan and others added 2 commits October 10, 2024 16:46
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso
Copy link
Collaborator

What about this eb2f67a

@munishchouhan
Copy link
Member Author

What about this eb2f67a

this is already being checked in extractCondaLockFile, i was trying to avoid the log processing

protected static String extractCondaLockFile(String logs) {
int start = logs.lastIndexOf(CONDA_LOCK_START)
int end = logs.lastIndexOf(CONDA_LOCK_END)
if( start >= end ) { // when build fails, there will be commands in the logs, so to avoid extracting wrong content
return null
}

@pditommaso
Copy link
Collaborator

That's check is cheap, better to keep the interface simpler and infer from the content

@pditommaso pditommaso merged commit 893cca0 into master Oct 11, 2024
1 check passed
@pditommaso pditommaso deleted the 684-condalock-extraction-error branch October 11, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Condalock extraction error
2 participants