Skip to content

added download icon and updated copy icon #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Conversation

munishchouhan
Copy link
Member

This PR will add download option for conda lock and build log and will use the icons from mdi
https://icon-sets.iconify.design/mdi/download/

Signed-off-by: munishchouhan <[email protected]>
@munishchouhan
Copy link
Member Author

locally tested:

Screen.Recording.2024-10-09.at.14.52.23.mov

@pditommaso
Copy link
Collaborator

Nice

@pditommaso
Copy link
Collaborator

let's add in this "base64 encode the PNG images and include inline too, rather than using external image files" as suggested in #650

@munishchouhan
Copy link
Member Author

let's add in this "base64 encode the PNG images and include inline too, rather than using external image files" as suggested in #650

ok sure

@munishchouhan
Copy link
Member Author

tested again locally:

Screen.Recording.2024-10-09.at.15.43.16.mov

@munishchouhan munishchouhan mentioned this pull request Oct 9, 2024
5 tasks
Signed-off-by: munishchouhan <[email protected]>
@munishchouhan
Copy link
Member Author

@pditommaso I have made most of the changes asked in #650

@munishchouhan munishchouhan self-assigned this Oct 9, 2024
@munishchouhan
Copy link
Member Author

inspect view
Screenshot 2024-10-09 at 16 34 17

@pditommaso pditommaso merged commit aaf2a43 into master Oct 9, 2024
4 checks passed
@pditommaso pditommaso deleted the add-copy-download-icon branch October 9, 2024 14:46
@pditommaso
Copy link
Collaborator

Nice job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants