refactored metrics 2 #549
Merged
refactored metrics 2 #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: munishchouhan <[email protected]>
Closed
pditommaso
reviewed
Jul 2, 2024
| response.count += entry.value | ||
| //split is used to extract the org name from the key like "metrics/o/seqera.io" => seqera.io | ||
| response.orgs.put(entry.key.split("/$MetricConstants.PREFIX_ORG/").last(), entry.value) | ||
| response.orgs.put(entry.key.split("/$MetricsConstants.PREFIX_ORG/").last(), entry.value) |
There was a problem hiding this comment.
Using a import static MetricsConstants.* would improve the readability of this
Signed-off-by: munishchouhan <[email protected]>
pditommaso
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last PR, there were some mismatches in comments and changes in files,
so creating new PR for that
This PR will do the following: