Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed failing test #539

Merged
merged 3 commits into from
Jul 1, 2024
Merged

fixed failing test #539

merged 3 commits into from
Jul 1, 2024

Conversation

munishchouhan
Copy link
Member

@munishchouhan munishchouhan commented Jun 24, 2024

This PR will mock version 1 manifest for failing test

@munishchouhan munishchouhan linked an issue Jun 24, 2024 that may be closed by this pull request
@munishchouhan munishchouhan requested a review from pditommaso June 24, 2024 21:29
@munishchouhan munishchouhan self-assigned this Jun 24, 2024
@munishchouhan
Copy link
Member Author

@pditommaso please review this, there is a test failing because if the change in container image

@pditommaso
Copy link
Collaborator

Closing in favour of 263b44d

@pditommaso pditommaso closed this Jun 29, 2024
@pditommaso pditommaso reopened this Jul 1, 2024
pditommaso referenced this pull request Jul 1, 2024
Signed-off-by: Paolo Di Tommaso <[email protected]>
@munishchouhan
Copy link
Member Author

@pditommaso conflicts resolved, please review

Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso pditommaso merged commit d987222 into master Jul 1, 2024
4 checks passed
@pditommaso pditommaso deleted the 538-test-failing-in-ci branch July 1, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failing in ci
2 participants