add skaffold configuration for local development #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Aguilera <[email protected]>
pditommaso
reviewed
Nov 4, 2022
README.md
Outdated
Comment on lines
260
to
263
| kubectl apply -f k8s/namespace-k3d.yml | ||
| kubectl apply -f k8s/accounts-k3d.yml | ||
| kubectl apply -f k8s/volumes-k3d.yml | ||
| kubectl apply -f k8s/surrealdb-k3d.yml |
There was a problem hiding this comment.
Can we put skaffold related files into k8s/skaffold/ dir?
Signed-off-by: Jorge Aguilera <[email protected]>
pditommaso
reviewed
Nov 7, 2022
k8s/dev/config-k3d.yml
Outdated
Comment on lines
23
to
24
| username: 'robot$developers' | ||
| password: 'qAElA1YJ4J7ktb9qt3ChpgMRJ5Cy9BJ0' |
There was a problem hiding this comment.
We have SEQERA_CR_USERNAME and SEQERA_CR_PASSWORD for this
pditommaso
reviewed
Nov 7, 2022
k8s/dev/cr-seqera-regcred.yml
Outdated
| metadata: | ||
| name: regcred | ||
| data: | ||
| .dockerconfigjson: eyJhdXRocyI6eyJjci5zZXFlcmEuaW8iOnsidXNlcm5hbWUiOiJyb2JvdCRkZXZlbG9wZXJzIiwicGFzc3dvcmQiOiJxQUVsQTFZSjRKN2t0YjlxdDNDaHBnTVJKNUN5OUJKMCIsImVtYWlsIjoiZGV2ZWxvcGVyc0BzZXFlcmEuaW8iLCJhdXRoIjoiY205aWIzUWtaR1YyWld4dmNHVnljenB4UVVWc1FURlpTalJLTjJ0MFlqbHhkRE5EYUhCblRWSktOVU41T1VKS01BPT0ifX19 |
There was a problem hiding this comment.
is this needed to access cr.seqera.io right? Wonder if there's something more safe for it? tagging @enekui
There was a problem hiding this comment.
at the end, as we are using a localhost:5000 registry it's not necessary. I'll remove it
Signed-off-by: Jorge Aguilera <[email protected]>
pditommaso
reviewed
Nov 7, 2022
pditommaso
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First configuration to run wave in a local cluster using k3d
Signed-off-by: Jorge Aguilera [email protected]