remove fixed registry configurations #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Aguilera <[email protected]>
Signed-off-by: Jorge Aguilera <[email protected]>
pditommaso
reviewed
Nov 2, 2022
pditommaso
reviewed
Nov 2, 2022
Signed-off-by: Jorge Aguilera <[email protected]>
pditommaso
reviewed
Nov 3, 2022
src/main/groovy/io/seqera/wave/auth/RegistryConfiguration.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Jorge Aguilera <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso
reviewed
Nov 3, 2022
| @ConfigurationProperties('wave') | ||
| @Context | ||
| @CompileStatic | ||
| class RegistryConfig { |
There was a problem hiding this comment.
Simplified to RegistryConfig to not overlap with RegistryCredentialsFactory
Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso
reviewed
Nov 3, 2022
| /** | ||
| * Registry static key pair as defined in the Wave config file | ||
| */ | ||
| static class RegistryKeys { |
There was a problem hiding this comment.
The registry name must be the same as the one specified in the method invocation. I've removed from this class.
|
Nice job! this is much more flexible and removes a lot of code! |
|
Always him #178 😠 |
yesterday I was working on it and I've created a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove fixed registry configurations from code and move them to configuration to allow include more registries without change code
the new configuration uses the full name of the registry as key and allows to specify which of them use as default