-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump view first iteration #187
Conversation
Signed-off-by: Paolo Di Tommaso <[email protected]>
I think include |
src/main/groovy/io/seqera/wave/service/persistence/PersistenceService.groovy
Show resolved
Hide resolved
yes, I saw there are many templating engines. Classic ones e.g. thymeleft, velocity, handlebars, etc and more recent ones. Have you seen rocker? it looks quite cool. In any case with any of them, I'm not getting how to handle page assets e.g. css, images, js files. any idea? |
I'm playing with Turbo and I like it approach. Rocker seems powerful but I need to read a little more because it seems more complex about assets it's "as easy" as include a static route in application.yml, for example
|
src/main/groovy/io/seqera/wave/service/persistence/impl/SurrealPersistenceService.groovy
Show resolved
Hide resolved
👍 |
Basic implementation for #186. This PR adds a view controller that shows some build metadata in a similar vein done for the completion email.
The HTML rendering was kept as simple as possible on purpose just using the email templating. In a future iteration better templating will be used.