Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump view first iteration #187

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Bump view first iteration #187

merged 1 commit into from
Oct 31, 2022

Conversation

pditommaso
Copy link
Collaborator

Basic implementation for #186. This PR adds a view controller that shows some build metadata in a similar vein done for the completion email.

The HTML rendering was kept as simple as possible on purpose just using the email templating. In a future iteration better templating will be used.

Signed-off-by: Paolo Di Tommaso <[email protected]>
@jorgeaguileraseqera
Copy link
Contributor

I think include micronaut-view subproject (mabye with thymeleaf it's very easy and we avoid dependencies between email and html

@pditommaso
Copy link
Collaborator Author

pditommaso commented Oct 31, 2022

yes, I saw there are many templating engines. Classic ones e.g. thymeleft, velocity, handlebars, etc and more recent ones. Have you seen rocker? it looks quite cool.

In any case with any of them, I'm not getting how to handle page assets e.g. css, images, js files. any idea?

@jorgeaguileraseqera
Copy link
Contributor

yes, I saw there are many templating engines. Classic ones e.g. thymeleft, velocity, handlebars, etc and more recent ones. Have you seen rocker? it looks quite cool.

In any case with any of them, I'm not getting how to handle page assets e.g. css, images, js files. any idea?

I'm playing with Turbo and I like it approach. Rocker seems powerful but I need to read a little more because it seems more complex

about assets it's "as easy" as include a static route in application.yml, for example

  router:
    static-resources:
      css:
        paths: 'classpath:views/css'
        mapping: '/css/**'
        enabled: true
      assets:
        paths: 'classpath:views/assets'
        mapping: '/assets/**'
        enabled: true
      js:
        paths: 'classpath:views/js'
        mapping: '/js/**'
        enabled: true

@pditommaso
Copy link
Collaborator Author

about assets it's "as easy" as include a static route in application.yml, for example

👍

@pditommaso pditommaso merged commit 2d5ca74 into master Oct 31, 2022
@pditommaso pditommaso deleted the build-view branch October 31, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants