return a clear error message when rate limit is hit

[jorgeaguileraseqera]

Plus test I've tested using a docker command line, and the error appears as:

docker pull localhost:9090/library/hello-world
Using default tag: latest
Error response from daemon: pull access denied for localhost:9090/library/hello-world, repository does not exist or may require 'docker login': denied: 127.0.0.1 request exceeded pull rate limit

closes #133

Signed-off-by: Jorge Aguilera [email protected]

[pditommaso]

think if it could not make more sense of changing the interface to return a boolean instead of an exception

wave/src/main/groovy/io/seqera/wave/ratelimit/RateLimiterService.groovy

Lines 12 to 14 in a4650e6

	void acquireBuild(AcquireRequest request) throws SlowDownException
	void acquirePull(AcquireRequest request) throws SlowDownException

and then throw the docker exception

[jorgeaguileraseqera]

think if it could not make more sense of changing the interface to return a boolean instead of an exception

wave/src/main/groovy/io/seqera/wave/ratelimit/RateLimiterService.groovy

Lines 12 to 14 in a4650e6

	void acquireBuild(AcquireRequest request) throws SlowDownException
	void acquirePull(AcquireRequest request) throws SlowDownException

and then throw the docker exception

also, we can catch the specific SlowDownException in the ErrorController and return a RegistryErrorResponse

[pditommaso]

Yes, but I feel like an ad hoc fix. In principle, that exception could the raised somewhere else.

This is why I think the rate limiter should just tell yes/how and the inoking method use the most appropriate exception

[jorgeaguileraseqera]

Ok, I just updated the PR with the ErrorController approach but will change it to this approach

[pditommaso]

ok, just removed the docker specific handler from the global error controller.