Build cache storage #129
Merged
Build cache storage #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Di Tommaso <[email protected]>
Refactor of BuildRequest to be serializable New RedisCacheStore store/retrieve json representations of BuildRequest New business rule: a build request is "completed" when the duration is set
|
uhh, plenty of conflicts. please, have a look to them |
I'm on it, didn't realize we have changes in master |
merge changes from master
jorgeaguileraseqera
force-pushed
the
issue-116-redis-build-status
branch
from
f305c2c
to
ca953b3
Compare
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
|
@jorgeaguileraseqera please have a quick look at lasted changes and we'll merge it |
|
can see you don't like @retryable at all :) |
|
too smart! 😆 |
jorgeaguileraseqera
added a commit
that referenced
this pull request
Sep 26, 2022
Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Jorge Aguilera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative implementation for build cache storage.
The CacheStore defines the operation it should be implemented.
The local version works fine.
However I have some problems with the Redis implementation. The PubSub pattern does seems to to work. Tests should be added