remove build pack artifacts #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is missing here? |
|
I'm removing LayerConfig from code |
|
Should this be considered completed? |
|
yes I'll update from master and remove the draft |
Signed-off-by: Jorge Aguilera <[email protected]> closes #100
Signed-off-by: Jorge Aguilera <[email protected]>
jorgeaguileraseqera
force-pushed
the
100-get-rid-of-container-layer-packing
branch
from
ab8d001 to
298575d
Compare
pditommaso
reviewed
Aug 29, 2022
wave-api/src/main/groovy/io/seqera/wave/api/ContainerLayer.groovy
Outdated
Show resolved
Hide resolved
pditommaso
reviewed
Aug 29, 2022
src/main/groovy/io/seqera/wave/util/ContainerConfigFactory.groovy
Outdated
Show resolved
Hide resolved
pditommaso
reviewed
Aug 29, 2022
src/main/groovy/io/seqera/wave/core/RegistryProxyService.groovy
Outdated
Show resolved
Hide resolved
|
Ok, i'll finalise this |
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jorge Aguilera [email protected]
closes #100