Skip to content

Commit

Permalink
Use runAsync instead supplyAsync
Browse files Browse the repository at this point in the history
Signed-off-by: Paolo Di Tommaso <[email protected]>
  • Loading branch information
pditommaso committed Nov 17, 2024
1 parent 328e9ea commit ffd0dac
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ class PullMetricsRequestsFilter implements HttpServerFilter {
final contentType = response.headers.get(HttpHeaders.CONTENT_TYPE)
if( contentType && contentType in MANIFEST_TYPES ) {
final route = routeHelper.parse(request.path)
CompletableFuture.supplyAsync(() -> metricsService.incrementPullsCounter(route.identity), executor)
CompletableFuture.runAsync(() -> metricsService.incrementPullsCounter(route.identity), executor)
final version = route.request?.containerConfig?.fusionVersion()
if (version) {
CompletableFuture.supplyAsync(() -> metricsService.incrementFusionPullsCounter(route.identity), executor)
CompletableFuture.runAsync(() -> metricsService.incrementFusionPullsCounter(route.identity), executor)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,8 @@ class ContainerBuildServiceImpl implements ContainerBuildService, JobHandler<Bui
}

//increment metrics
CompletableFuture.supplyAsync(() -> metricsService.incrementBuildsCounter(request.identity), executor)
CompletableFuture
.runAsync(() -> metricsService.incrementBuildsCounter(request.identity), executor)

// launch the build async
CompletableFuture
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class ContainerMirrorServiceImpl implements ContainerMirrorService, JobHandler<M
if( store.putIfAbsent(request.targetImage, MirrorEntry.of(request))) {
log.info "== Container mirror submitted - request=$request"
//increment mirror counter
CompletableFuture.supplyAsync(() -> metricsService.incrementMirrorsCounter(request.identity), ioExecutor)
CompletableFuture.runAsync(() -> metricsService.incrementMirrorsCounter(request.identity), ioExecutor)
jobService.launchMirror(request)
return new BuildTrack(request.mirrorId, request.targetImage, false, null)
}
Expand Down

0 comments on commit ffd0dac

Please sign in to comment.