Merge pull request #733 from seqeralabs/mn-4.6

Upgrade to Micronaut 4.6

src/main/groovy/io/seqera/wave/configuration/ScanConfig.groovy

@@ -95,7 +95,11 @@ class ScanConfig {
     @Memoized
     Path getCacheDirectory() {
         final result = Path.of(buildDirectory).toAbsolutePath().resolve('.trivy-cache')
-        Files.createDirectories(result)
+        try {
+            Files.createDirectories(result)
+        } catch (IOException e) {
+            log.error "Unable to create scan cache directory=${result} - cause: ${e.message}"
+        }
         return result
     }
 

src/test/groovy/io/seqera/wave/controller/ContainerControllerTest.groovy

@@ -21,7 +21,6 @@ package io.seqera.wave.controller
 import spock.lang.Specification
 import spock.lang.Unroll
 
-import java.nio.file.Path
 import java.time.Instant
 import java.time.temporal.ChronoUnit
 
@@ -42,7 +41,6 @@ import io.seqera.wave.api.SubmitContainerTokenRequest
 import io.seqera.wave.api.SubmitContainerTokenResponse
 import io.seqera.wave.config.CondaOpts
 import io.seqera.wave.configuration.BuildConfig
-import io.seqera.wave.configuration.ScanConfig
 import io.seqera.wave.core.ContainerPlatform
 import io.seqera.wave.core.RegistryProxyService
 import io.seqera.wave.exception.BadRequestException
@@ -74,7 +72,6 @@ import jakarta.inject.Inject
  * @author Paolo Di Tommaso <[email protected]>
  */
 @MicronautTest
-@Property(name='wave.build.workspace', value='/some/wsp')
 @Property(name='wave.build.repo', value='wave/build')
 @Property(name='wave.build.cache', value='wave/build/cache')
 class ContainerControllerTest extends Specification {
@@ -103,13 +100,6 @@ class ContainerControllerTest extends Specification {
         Mock(JobService)
     }
 
-    @MockBean(ScanConfig)
-    ScanConfig mockScanConfig() {
-        Mock(ScanConfig) {
-            getCacheDirectory() >> Path.of('/build/cache/dir')
-        }
-    }
-
     @MockBean(RegistryProxyService)
     RegistryProxyService mockProxy() {
         Mock(RegistryProxyService) {

src/test/groovy/io/seqera/wave/controller/RegistryControllerLocalTest.groovy

@@ -142,17 +142,17 @@ class RegistryControllerLocalTest extends Specification implements DockerRegistr
                 h.add('Accept', it)
             }
         })
-        HttpResponse<Map> response = client.toBlocking().exchange(request, String)
+        HttpResponse<String> response = client.toBlocking().exchange(request, String)
 
         then:
         response.status() == HttpStatus.OK
 
         when:
-        def parsedBody = new JsonSlurper().parseText(response.body.get())
+        def parsedBody = new JsonSlurper().parseText(response.body.get()) as Map
         and:
         def list = parsedBody.manifests.collect {
             String type = it.mediaType.contains("manifest") ? "manifests" : "blobs"
-            "/v2/$IMAGE/$type/$it.digest"
+            return "/v2/$IMAGE/$type/$it.digest" as String
         }
         and:
         boolean fails = list.find{ url ->

src/test/groovy/io/seqera/wave/service/CredentialsServiceTest.groovy

@@ -166,8 +166,7 @@ class CredentialsServiceTest extends Specification {
                 registry: 'docker.io'
         )
         and:
-
-        def identity = new PlatformId(new User(id:10), 11,"token",'tower.io', '101')
+        def identity = new PlatformId(new User(id:10), 100,"token",'tower.io', '101')
         def auth = JwtAuth.of(identity)
 
         when:
@@ -183,7 +182,7 @@ class CredentialsServiceTest extends Specification {
         )
 
         and: 'non matching credentials are listed'
-        1 * towerClient.listCredentials('tower.io',auth,11) >> CompletableFuture.completedFuture(new ListCredentialsResponse(
+        1 * towerClient.listCredentials('tower.io',auth,100) >> CompletableFuture.completedFuture(new ListCredentialsResponse(
                 credentials: [nonContainerRegistryCredentials,otherRegistryCredentials]
         ))
 
@@ -220,8 +219,8 @@ class CredentialsServiceTest extends Specification {
 
     def 'should get registry creds from compute creds when not found in tower credentials'() {
         given: 'a tower user in a workspace on a specific instance with a valid token'
-        def userId = 12
-        def workspaceId = 12
+        def userId = 10
+        def workspaceId = 100
         def token = "valid-token"
         def towerEndpoint = "http://tower.io:9090"
         def workflowId = "id123"

src/test/groovy/io/seqera/wave/service/builder/KubeBuildStrategyTest.groovy

@@ -21,13 +21,11 @@ package io.seqera.wave.service.builder
 import spock.lang.Specification
 
 import java.nio.file.Files
-import java.nio.file.Path
 import java.time.Duration
 
 import io.micronaut.context.annotation.Property
 import io.micronaut.test.annotation.MockBean
 import io.micronaut.test.extensions.spock.annotation.MicronautTest
-import io.seqera.wave.configuration.ScanConfig
 import io.seqera.wave.core.ContainerPlatform
 import io.seqera.wave.service.k8s.K8sService
 import io.seqera.wave.service.k8s.K8sServiceImpl
@@ -40,11 +38,9 @@ import jakarta.inject.Inject
  * @author Paolo Di Tommaso <[email protected]>
  */
 @MicronautTest
-@Property(name="wave.build.workspace",value="/build/work")
 @Property(name="wave.build.k8s.namespace",value="foo")
 @Property(name="wave.build.k8s.configPath",value="/home/kube.config")
 @Property(name="wave.build.k8s.storage.claimName",value="bar")
-@Property(name="wave.build.k8s.storage.mountPath",value="/build")
 @Property(name='wave.build.k8s.node-selector[linux/amd64]',value="service=wave-build")
 @Property(name='wave.build.k8s.node-selector[linux/arm64]',value="service=wave-build-arm64")
 class KubeBuildStrategyTest extends Specification {
@@ -60,12 +56,6 @@ class KubeBuildStrategyTest extends Specification {
         Mock(K8sService)
     }
 
-    @MockBean(ScanConfig)
-    ScanConfig mockScanConfig() {
-        Mock(ScanConfig) {
-            getCacheDirectory() >> Path.of('/build/cache/dir')
-        }
-    }
 
     def "request to build a container with right selector"(){
         given: