Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings and release error #51

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

munishchouhan
Copy link
Member

@munishchouhan munishchouhan commented Dec 19, 2023

This PR will fix build warnings and release error:

  1. remove components: 'native-image', which is no more required in Java 21
  2. Added Java version in jreleaser.yml required by fatjar

@munishchouhan munishchouhan linked an issue Dec 19, 2023 that may be closed by this pull request
@pditommaso
Copy link
Contributor

Should this fix the release?

@munishchouhan
Copy link
Member Author

munishchouhan commented Dec 19, 2023

Should this fix the release?

I am testing if these warnings are the reasons for the release skip
https://github.com/munishchouhan/wave-cli/actions/runs/7266156843

@munishchouhan
Copy link
Member Author

These warnings are not the reason of release skip
Now I am testing with the new changes we made after the last release
https://github.com/munishchouhan/wave-cli/actions/runs/7266051892

@munishchouhan
Copy link
Member Author

found one error in release job, latest commit will fix it
this maybe the cause

Error:  == JReleaser ==
Error:  distribution.wave-cli-jar.type is set to SINGLE_JAR but neither distribution.wave-cli-jar.java nor project.java have been set
JReleaser has not been properly configured.
distribution.wave-cli-jar.type is set to SINGLE_JAR but neither distribution.wave-cli-jar.java nor project.java have been set

Error: Process completed with exit code 1.

@munishchouhan munishchouhan changed the title components: 'native-image' removed Fix build warnings and release error Dec 19, 2023
@munishchouhan
Copy link
Member Author

@pditommaso please review

@pditommaso pditommaso merged commit 997cdf8 into master Dec 20, 2023
@munishchouhan munishchouhan deleted the 50-build-warning-to-be-addressed branch June 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build warning to be addressed
2 participants