PLAT-1245 - Delete command for Data Studio #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgi-seqera
requested review from
t0randr,
weronikasosnowskaseqera and
endre-seqera
endre-seqera
approved these changes
Jan 30, 2025
| public final String workspaceRef; | ||
|
|
||
| public DataStudioDeleted(String sessionId, String userSuppliedStudioIdentifier, Long workspaceId, String workspaceRef) { | ||
| this.sessionId = sessionId; |
There was a problem hiding this comment.
minor: sessionId and workspaceId might be removed, if unused
There was a problem hiding this comment.
good point, updated
weronikasosnowskaseqera
approved these changes
Jan 30, 2025
| """)).withContentType(MediaType.APPLICATION_JSON) | ||
| ); | ||
|
|
||
| ExecOut out = exec(format, mock, "studios", "stop", "-w", "75887156211589", "-n" ,"studio-a66d"); |
There was a problem hiding this comment.
PR is implementing delete, are you adding those tests just because you forgot with other PR or It's a mistake?
There was a problem hiding this comment.
Yeaah, in the previous PR I had to resolve a some merge conflicts after rebasing and somehow these couple of tests got dropped accidentally after so I am re-adding them in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Work relates to task: https://seqera.atlassian.net/browse/PLAT-1245
Summary: add the ability to delete a data studio via the CLI.
Testing