Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seqerakit docs port #296

Merged
merged 39 commits into from
Dec 2, 2024
Merged

Seqerakit docs port #296

merged 39 commits into from
Dec 2, 2024

Conversation

llewellyn-sl
Copy link
Contributor

@llewellyn-sl llewellyn-sl commented Nov 11, 2024 •
edited
Loading

@netlify /platform/24.1/seqerakit/installation

Ports and simplifies the Seqerakit docs into Platform Developer Tools.

TODO:

  • Port final pages to 24.2, 23.4, and 23.3
  • Clean up seqerakit repo

@netlify Netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit 1fd23e0
🔍 Latest deploy log https://app.netlify.com/sites/seqera-docs/deploys/674da7b098f6e8000806d7a1
😎 Deploy Preview https://deploy-preview-296--seqera-docs.netlify.app/platform/24.1/seqerakit/installation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@llewellyn-sl llewellyn-sl self-assigned this Nov 15, 2024
@llewellyn-sl llewellyn-sl marked this pull request as ready for review November 17, 2024 20:00
justinegeffen
justinegeffen reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback about formatting which we'll apply across other developer docs if we're all in agreement.

justinegeffen
justinegeffen approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you so much!

@justinegeffen justinegeffen added 1. Editor review Needs a language review 1. Dev/PM/SME Needs a review by a Dev/PM/SME and removed 1. Editor review Needs a language review labels Nov 21, 2024
@christopher-hakkaart
Copy link
Member

christopher-hakkaart commented Nov 22, 2024 •
edited
Loading

I've added two small comments. I wouldn't consider either of these blocking.

christopher-hakkaart
christopher-hakkaart approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

Minor suggestions:

  • I think Seqerakit in the descriptions qualifies as the product name and should be capitalized
  • --help is an option not a parameter
  • Flags are boolean options (please correct me if I'm wrong)

justinegeffen
justinegeffen approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Minor feedback.

llewellyn-sl and others added 14 commits December 2, 2024 13:32
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/seqerakit/commands.mdx
87839cc 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/seqerakit/commands.mdx
ac4cf57 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/seqerakit/commands.mdx
e8aa6dc 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/seqerakit/commands.mdx
c79b9a5 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/seqerakit/installation.mdx
d2261bc 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/seqerakit/installation.mdx
6220ccb 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/seqerakit/templates.mdx
c30acfd 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @justinegeffen
Update platform_versioned_docs/version-24.1/seqerakit/templates.mdx
df73a6c 
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @justinegeffen
Update platform_versioned_docs/version-24.1/seqerakit/templates.mdx
fb106f4 
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Merge branch 'master' into seqerakit-docs-port
2804ad1
@llewellyn-sl
Code review suggestions, port to latest and older versions
a2020b2
@llewellyn-sl
Port CLI docs to 23.3 to fix broken links
757cbae
@llewellyn-sl
Fix broken links in 23.3 cli docs
20bfaec
@llewellyn-sl
Update overview.mdx
1fd23e0
@llewellyn-sl llewellyn-sl added 3. Reviews complete Reviews complete. Remove label when confirmed in prod. and removed 1. Dev/PM/SME Needs a review by a Dev/PM/SME labels Dec 2, 2024
@llewellyn-sl llewellyn-sl merged commit 490ab09 into master Dec 2, 2024
6 checks passed
@llewellyn-sl llewellyn-sl deleted the seqerakit-docs-port branch December 2, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinegeffen justinegeffen justinegeffen approved these changes

@christopher-hakkaart christopher-hakkaart christopher-hakkaart approved these changes

@ejseqera ejseqera ejseqera approved these changes

@jason-seqera jason-seqera Awaiting requested review from jason-seqera

@andrew-dawson-seqera andrew-dawson-seqera Awaiting requested review from andrew-dawson-seqera

Assignees

@llewellyn-sl llewellyn-sl

Labels
3. Reviews complete Reviews complete. Remove label when confirmed in prod.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@llewellyn-sl @christopher-hakkaart @jason-seqera @justinegeffen @ejseqera