Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/line function #283

Merged
merged 11 commits into from
Oct 22, 2024
Merged

Conversation

AHReccese
Copy link

@AHReccese AHReccese commented Oct 18, 2024

Reference Issues/PRs

#272

What does this implement/fix? Explain your changes.

Any other comments?

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts 💯

  1. Here(90679af), I made some changes to fix tests, so please update your local branch

  2. Take a look at my comments

  3. Add lprint and line functions to __init__.py

  4. Add some tests for lprint and line at the top of tests/test.py

⚠️ We will update README.md in another pull request.

art/functions.py Outdated Show resolved Hide resolved
art/functions.py Outdated Show resolved Hide resolved
art/functions.py Outdated Show resolved Hide resolved
art/params.py Outdated Show resolved Hide resolved
art/params.py Outdated Show resolved Hide resolved
art/params.py Outdated Show resolved Hide resolved
art/functions.py Outdated Show resolved Hide resolved
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sadrasabouri sadrasabouri merged commit 286b293 into sepandhaghighi:dev Oct 22, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants