Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI #220

Merged
merged 11 commits into from
Mar 5, 2023
Merged

CLI #220

merged 11 commits into from
Mar 5, 2023

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • README.md modified
  • help_func function modified
  • CLI mode updated

Any other comments?

@sepandhaghighi sepandhaghighi added this to the art 5.9 milestone Mar 5, 2023
@sepandhaghighi sepandhaghighi self-assigned this Mar 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023

Codecov Report

Merging #220 (dc8bf88) into dev (0870f9c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #220      +/-   ##
==========================================
- Coverage   99.83%   99.83%   -0.00%     
==========================================
  Files           7        7              
  Lines        1170     1163       -7     
  Branches       74       74              
==========================================
- Hits         1168     1161       -7     
  Misses          1        1              
  Partials        1        1              
Impacted Files Coverage Δ
art/art.py 99.26% <100.00%> (-0.02%) ⬇️
art/art_param.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

README.md Outdated
Comment on lines 750 to 753
- Text : `art text yourtext fontname(optional)`
- Art : `art shape art_name` or `art art art_name`
- Save : `art save yourtext fontname(optional)`
- All : `art all yourtext`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make them a little bit more comprehensive? Like:

art text [yourtext] [fontname(optional)]

which shows the difference between keywords and parameters.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 🚀

@@ -103,3 +108,7 @@ def select_test(test_name="TEST"):
help_func()
else:
help_func()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As code factor mentioned, this function is too long.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this issue in our discord server

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in dc8bf88

@sadrasabouri sadrasabouri merged commit cf7f6ed into dev Mar 5, 2023
@sadrasabouri sadrasabouri deleted the CLI branch March 5, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants