Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/sbom.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,14 @@ jobs:
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Install Syft
run: |
curl -sSfL -o "$RUNNER_TEMP/syft.tar.gz" "https://github.com/anchore/syft/releases/download/v1.20.0/syft_1.20.0_linux_amd64.tar.gz"
tar -xzf "$RUNNER_TEMP/syft.tar.gz" -C "$RUNNER_TEMP" syft

- name: Generate CycloneDX SBOM
uses: anchore/sbom-action@57aae528053a48a3f6235f2d9461b05fbcb7366d # v0.23.1
with:
path: .
format: cyclonedx-json
output-file: bandscope-sbom.cdx.json
run: |
"$RUNNER_TEMP/syft" dir:. -o cyclonedx-json=bandscope-sbom.cdx.json
Comment on lines +41 to +48
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

anchore syft latest release version 2026

💡 Result:

Anchore Syft latest release (as of March 12, 2026) is v1.42.2, published March 9, 2026. [1]

Source: GitHub releases page for anchore/syft. [1]


🏁 Script executed:

# Check if dependency policy exists
find . -name "dependency-policy.md" -o -name "*security*" -type f | head -20

Repository: seonghobae/bandscope

Length of output: 281


🏁 Script executed:

cat -n ./docs/security/dependency-policy.md

Repository: seonghobae/bandscope

Length of output: 6804


🏁 Script executed:

# Check if supplemental inventory exists and contains Syft
find . -name "supplemental-component-inventory.json" -type f

Repository: seonghobae/bandscope

Length of output: 116


🏁 Script executed:

cat -n ./supply-chain/supplemental-component-inventory.json

Repository: seonghobae/bandscope

Length of output: 448


🏁 Script executed:

# Check the .github/workflows/sbom.yml file to understand context
head -50 .github/workflows/sbom.yml

Repository: seonghobae/bandscope

Length of output: 1229


🏁 Script executed:

cat -n scripts/checks/verify_supply_chain.py | head -100

Repository: seonghobae/bandscope

Length of output: 4825


Syft 바이너리 다운로드가 의존성 정책 요구사항을 위반합니다.

이 변경사항은 저장소의 의존성 정책(docs/security/dependency-policy.md)의 두 가지 중요한 요구사항을 위반합니다:

  1. 체크섬 검증 누락 (정책 72줄): 릴리스 산출물은 체크섬이나 동등한 무결성 데이터를 포함해야 합니다. 현재 코드는 외부 바이너리를 검증 없이 다운로드하고 실행하므로 공급망 공격에 취약합니다.

  2. 추적 누락 (정책 70줄): Syft는 supply-chain/supplemental-component-inventory.json에 추적되어야 하는 번들된 바이너리입니다. 현재 인벤토리는 비어있습니다.

또한 Syft v1.20.0은 현재 최신 릴리스인 v1.42.2(2026년 3월 9일)에서 22개 마이너 버전 뒤처져 있어 보안 패치가 누락되어 있습니다.

다음을 수정해야 합니다:

  • SHA-256 체크섬 검증 추가
  • Syft를 supplemental-component-inventory.json에 추가 (소스 URL, 버전, 체크섬, 라이선스 포함)
  • 최신 안정 버전으로 업그레이드 고려
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/sbom.yml around lines 41 - 48, The workflow currently
downloads and runs an unaudited Syft binary in the "Install Syft" / "Generate
CycloneDX SBOM" steps; modify the job to (1) pin or bump the Syft version to a
current stable release (replace v1.20.0 with the chosen version string used in
the workflow), (2) download the release artifacts and verify the SHA-256
checksum before extracting/executing (compute and compare against a hardcoded
checksum value you add to the workflow for the syft_*.tar.gz file), and (3) add
an entry for Syft into supply-chain/supplemental-component-inventory.json
including source URL, version, SHA-256 checksum, and license fields to satisfy
docs/security/dependency-policy.md requirements; ensure the workflow errors out
if checksum verification fails.


- name: Upload SBOM artifact
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
Expand Down
1 change: 1 addition & 0 deletions ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ Last updated: 2026-03-11
- Shared contracts live in `packages/shared-types` so the UI can evolve without importing Python internals.
- Shared contracts should ultimately model section, role, cue, confidence, and export artifacts explicitly enough that desktop UI and analysis outputs do not invent their own parallel schemas.
- The current shared-types baseline includes a rehearsal-domain fixture that exercises section, role, cue, confidence, provenance, and export-summary fields in the desktop shell before the full analysis pipeline lands.
- Local analysis orchestration uses typed Tauri IPC commands and a Python subprocess over stdin/stdout rather than a loopback HTTP listener.
- Product and UX decisions should prefer rehearsal-first simplicity while still maintaining high analytical accuracy.
- Security decisions should prefer allowlisted narrow capabilities over generic convenience APIs.

Expand Down
1 change: 1 addition & 0 deletions apps/desktop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"test": "node -e \"require('node:fs').mkdirSync('coverage/.tmp', { recursive: true })\" && vitest run --coverage"
},
"dependencies": {
"@tauri-apps/api": "^2.8.0",
"@bandscope/shared-types": "0.1.0",
"react": "^19.2.4",
"react-dom": "^19.2.4"
Expand Down
3 changes: 3 additions & 0 deletions apps/desktop/src-tauri/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions apps/desktop/src-tauri/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ edition = "2021"
tauri-build = { version = "2" }

[dependencies]
serde = { version = "1", features = ["derive"] }
serde_json = "1"
tauri = { version = "2.3.1" }
time = { version = "0.3", features = ["formatting", "macros"] }

[features]
default = []
8 changes: 7 additions & 1 deletion apps/desktop/src-tauri/build.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
fn main() {
tauri_build::build()
tauri_build::try_build(
tauri_build::Attributes::new().app_manifest(
tauri_build::AppManifest::new()
.commands(&["start_analysis_job", "get_analysis_job_status"]),
),
)
.expect("failed to build tauri application manifest");
}
11 changes: 11 additions & 0 deletions apps/desktop/src-tauri/capabilities/main.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"$schema": "../gen/schemas/desktop-schema.json",
"identifier": "main-capability",
"description": "Capability for the main BandScope window to use the analysis orchestration commands.",
"windows": ["main"],
"permissions": [
"core:default",
"allow-start-analysis-job",
"allow-get-analysis-job-status"
]
}
1 change: 1 addition & 0 deletions apps/desktop/src-tauri/gen/schemas/acl-manifests.json

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions apps/desktop/src-tauri/gen/schemas/capabilities.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"main-capability":{"identifier":"main-capability","description":"Capability for the main BandScope window to use the analysis orchestration commands.","local":true,"windows":["main"],"permissions":["core:default","allow-start-analysis-job","allow-get-analysis-job-status"]}}
2,268 changes: 2,268 additions & 0 deletions apps/desktop/src-tauri/gen/schemas/desktop-schema.json

Large diffs are not rendered by default.

2,268 changes: 2,268 additions & 0 deletions apps/desktop/src-tauri/gen/schemas/macOS-schema.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Automatically generated - DO NOT EDIT!

[[permission]]
identifier = "allow-get-analysis-job-status"
description = "Enables the get_analysis_job_status command without any pre-configured scope."
commands.allow = ["get_analysis_job_status"]

[[permission]]
identifier = "deny-get-analysis-job-status"
description = "Denies the get_analysis_job_status command without any pre-configured scope."
commands.deny = ["get_analysis_job_status"]
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Automatically generated - DO NOT EDIT!

[[permission]]
identifier = "allow-start-analysis-job"
description = "Enables the start_analysis_job command without any pre-configured scope."
commands.allow = ["start_analysis_job"]

[[permission]]
identifier = "deny-start-analysis-job"
description = "Denies the start_analysis_job command without any pre-configured scope."
commands.deny = ["start_analysis_job"]
Loading
Loading