-
Notifications
You must be signed in to change notification settings - Fork 0
docs: align TRD with rehearsal domain model #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # BandScope Rehearsal Domain Model | ||
|
|
||
| ## Role taxonomy and extraction targets | ||
|
|
||
| BandScope models a song as rehearsal-facing roles, not only as a single global harmonic summary. | ||
|
|
||
| - A `role` can be an instrument role, a vocal role, or a hand-specific subdivision when the arrangement exposes it clearly. | ||
| - Example roles include bass guitar, guitar, Keyboard 1 left hand, Keyboard 1 right hand, Keyboard 2 left hand, Keyboard 2 right hand, lead vocal, backing vocal harmony, horns, and strings. | ||
| - The technical goal is not unlimited score transcription. The goal is enough role separation to make rehearsal decisions per player or role. | ||
|
|
||
| ## Harmony by section and role | ||
|
|
||
| - Harmony should be modeled per section and per role. | ||
| - Different roles may carry different voicings or harmonic functions at the same moment. | ||
| - The shared contract must not collapse those differences into one global chord answer when the arrangement clearly separates them. | ||
|
|
||
| ## Keyboard hands and vocal modeling | ||
|
|
||
| - Keyboard hands should be modeled separately when left-hand and right-hand material diverge enough to affect rehearsal. | ||
| - Lead vocals and backing vocals should be modeled separately when melody, harmony stack, or entry timing differ. | ||
| - Vocal-specific outputs should support lyric-linked cue anchors, range pressure, and harmony-entry timing. | ||
|
|
||
| ## Form, roadmap, and cue anchors | ||
|
|
||
| - A section model should support intro, verse, pre-chorus, chorus, bridge, outro, tags, pickups, stops, and handoffs. | ||
| - A rehearsal roadmap should expose who enters, who drops out, and where the band must re-enter together. | ||
| - Cue anchors should support lyric phrases, count-based entries, or section-transition markers. | ||
|
|
||
| ## Groove cues and rhythmic feel | ||
|
|
||
| - Groove guidance should include practical rehearsal cues such as straight versus swing feel, stop-time moments, sustained versus choppy roles, and shared hits. | ||
| - The purpose is rehearsal coordination, not notation-level rhythm engraving. | ||
|
|
||
| ## Transposition, capo, tuning, and simplification guidance | ||
|
|
||
| - A role output may include concert-key versus player-key transposition, capo suggestions, likely tuning or setup notes, and rehearsal-safe simplifications. | ||
| - Simplification guidance should separate must-play material from optional color tones or tonight-safe reductions. | ||
|
|
||
| ## Confidence, provenance, and manual edits | ||
|
|
||
| - Confidence must be available per section and per role. | ||
| - Manual corrections should preserve provenance so BandScope can distinguish model guesses from user-confirmed edits. | ||
| - Rehearsal prioritization should be able to use low-confidence areas as one source of urgency. | ||
|
|
||
| ## Cue sheet and chart exports | ||
|
|
||
| - Exports should be compact rehearsal artifacts rather than DAW sessions or engraved notation. | ||
| - Acceptable examples include cue sheets, section roadmaps, role notes, lyric-linked anchors, and chart-style summaries. | ||
| - Export formats must stay aligned with `docs/security/app-security.md` export safety rules. | ||
|
|
||
| ## Rehearsal prioritization | ||
|
|
||
| - The system should be able to rank what matters first by role and by section. | ||
| - Typical priority drivers include difficult entries, dense overlap, low-confidence harmony, setup changes, and likely train-wreck sections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.