Harden release artifact extraction#202
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughSummary by CodeRabbit릴리스 노트
Walkthrough빌드 워크플로우에서 Changes
Sequence DiagramsequenceDiagram
participant Workflow as build-baseline.yml
participant Artifact as actions/download-artifact
participant Extractor as extract_release_artifacts.py
participant Validator as verify_supply_chain.py
participant Output as artifacts/
Workflow->>Artifact: 요청 (skip-decompress: true)
Artifact-->>Workflow: ZIP 파일 반환 (압축된 상태)
Workflow->>Extractor: 다운로드된 ZIP 전달
activate Extractor
Extractor->>Extractor: 파일명 목록 검증
Extractor->>Extractor: 경로 이동 및 심볼릭 링크 확인
Extractor->>Extractor: 파일 크기 제한 검증
Extractor->>Output: 검증된 파일 추출
Extractor-->>Workflow: 추출 완료
deactivate Extractor
Validator->>Workflow: 워크플로우 검증
Validator->>Validator: skip-decompress: true 확인
Validator->>Validator: 추출기 단계 실행 확인
Validator-->>Validator: 검증 성공
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Review rate limit: 4/5 reviews remaining, refill in 12 minutes. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip-decompress: trueand extract with repo-owned validation before release asset selection.Validation
uv run --project services/analysis-engine pytest services/analysis-engine/tests/test_supply_chain_policy.py -q→ 102 passeduv run --project services/analysis-engine ruff check scripts/release/extract_release_artifacts.py scripts/checks/verify_supply_chain.py services/analysis-engine/tests/test_supply_chain_policy.py→ All checks passedpython3 scripts/checks/verify_supply_chain.py→ Supply-chain verification passedpython3 scripts/checks/security_gates.py→ Security pattern gate passedgit diff --check→ no outputSecurity Notes
select_release_assets.pyvalidation complete.skip-decompress: trueunder thedownload-artifactwith:mapping and a required, non-conditional extractor step before release asset validation.Closes #201.