fix: stabilize desktop YouTube import fallback#165
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invokewhen no usable native bridge exists.Verification
npx vitest run src/lib/analysis.test.ts(red first: 2 failing fallback tests, then 4 passing)npm run testinapps/desktop(40 passed, 100% covered files)npm run lintinapps/desktopnpm run typecheckinapps/desktopnpm run buildinapps/desktopnpm audit --workspaces --audit-level=high(0 vulnerabilities)./scripts/harness/quickcheck.sh(passed on clean PR branch)유튜브 가져오기, sawyoutube-preview.m4a, clicked분석 시작, saw구간 흐름; no new console errors from the import/start flow.Security Notes
youtube.com/subdomain/watch?v=...URLs or single-segmentyoutu.beURLs, matching the native command allowlist.invokewhen the Tauri v2 bridge exposes a callableinvokefunction or the existing legacy shim is present.