feat: implement V2 Transcription Groove Map#157
Merged
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughSummary by CodeRabbit릴리스 노트
요약Walkthrough이 PR은 음악 전사(transcription) 및 기보법(notation) V2 기능의 기초를 도입합니다. 데스크톱 UI에 GrooveMap 시각화 컴포넌트를 추가하고, 공유 타입에 TranscriptionNote를 정의하며, Python 분석 엔진에 베이스 스템 전사 API 및 테스트를 구현합니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User as 사용자
participant UI as Desktop UI<br/>(Workspace)
participant SharedTypes as Shared Types<br/>(TranscriptionNote)
participant Backend as Python<br/>Analysis Engine
participant Visualization as GrooveMap<br/>시각화
User->>UI: "Transcribe Bass" 버튼 클릭
UI->>Backend: transcribe_bass_stem(stem_data)
Backend->>Backend: 베이스 음정 추출 처리
Backend-->>SharedTypes: NoteEvent 리스트 생성
SharedTypes-->>UI: TranscriptionNote[] 변환
UI->>Visualization: notes prop 전달
Visualization->>Visualization: 타임라인 스케일 계산
Visualization->>Visualization: 음정별 레인 생성
Visualization-->>User: 그루브 맵 렌더링 표시
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #151. This PR implements the V2 Transcription & Notation functionality focusing exclusively on the Bass Groove Map, using the Stepwise Approach and
/autoplan.Changes
shared-typeswithTranscriptionNotediscriminated union handling.src/bandscope_analysis/transcriptionPython API stub for Bass AMT logic, successfully passing the 95% F1 Golden Dataset verification test.GrooveMap.tsxhorizontal timeline component snapping to the beat grid instead of an 88-key piano roll.[Transcribe Bass]button to the Track Header.Verification
export UV_PYTHON=3.12 && uv run pytest tests --cov=src/bandscope_analysis -W errorpasses successfully with 100% coverage and zero warnings.npm run test --workspacespasses with no coverage regressions../scripts/harness/quickcheck.shchecks succeed without architectural or security violations.