Log TLS failures when initializing the backend #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Plourde <[email protected]>
echlebek
approved these changes
Apr 14, 2020
added 3 commits
April 15, 2020 10:44
Signed-off-by: Simon Plourde <[email protected]>
Signed-off-by: Simon Plourde <[email protected]>
Signed-off-by: Simon Plourde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simon Plourde [email protected]
What is this change?
It removes the use of a blocking client when attempting to initialize the backend, in order to have etcd log any TLS error encountered.
See #3663 (comment) for more context.
It also adds a
--timeoutflag to thesensu-backend initcommand.Why is this change necessary?
This is a workaround for #3663. We can probably implement a better solution with a blocking client once this PR is released and etcd is updated to use it.
Does your change need a Changelog entry?
Added
Do you need clarification on anything?
Nope
Were there any complications while making this change?
go-grpc is not easy 😅
Have you reviewed and updated the documentation for this change? Is new documentation required?
Nope
How did you verify this change?
Manually tested.
Is this change a patch?
I'd say so