Re-write tracing middleware tests to use prometheus_client/testutil #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testutil package was introduced in v0.9 and exposes some helpers for for writing simple unit tests. Signed-off-by: James Phillips <[email protected]>
echlebek
added a commit
that referenced
this pull request
Oct 21, 2019
I originally intended to upgrade etcd to 3.4.2, but at this time, the module is broken, and cannot be included, under the original import path, or the new go.etcd.io import path. See etcd-io/etcd#11154 for more info. Closes #3278 Signed-off-by: Eric Chlebek <[email protected]> * Re-write tracing middleware tests to use prometheus_client/testutil (#3342) The testutil package was introduced in v0.9 and exposes some helpers for for writing simple unit tests. Signed-off-by: James Phillips <[email protected]>
echlebek
added a commit
that referenced
this pull request
Nov 1, 2019
I originally intended to upgrade etcd to 3.4.2, but at this time, the module is broken, and cannot be included, under the original import path, or the new go.etcd.io import path. See etcd-io/etcd#11154 for more info. Closes #3278 Signed-off-by: Eric Chlebek <[email protected]> * Re-write tracing middleware tests to use prometheus_client/testutil (#3342) The testutil package was introduced in v0.9 and exposes some helpers for for writing simple unit tests. Signed-off-by: James Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testutil package was introduced in v0.9 and exposes some helpers for
for writing simple unit tests.
Signed-off-by: James Phillips [email protected]