Create parent directory when writing output to -fo destination file#531
Merged
Conversation
Agent-Logs-Url: https://github.com/sensslen/nuget-license/sessions/ea8e4ba7-7c5c-49ca-afad-75ef4391b666 Co-authored-by: sensslen <3428860+sensslen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix parent directory creation for -fo output files
Create parent directory when writing output to -fo destination file
May 6, 2026
|
sensslen
approved these changes
May 6, 2026
This was referenced May 7, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-fo/--output-filefails when the specified file's parent directory doesn't exist —GetOutputStreamcallsFileMode.Createdirectly without ensuring the directory exists, unlike-dwhich already callsCreateDirectorybefore use.Changes
LicenseValidationOrchestrator.GetOutputStream: Extracts the directory from the resolved full path and calls_fileSystem.Directory.CreateDirectoryif it doesn't already exist before opening the file stream.LicenseValidationOrchestratorTest: AddsValidateAsync_WithDestinationFileInNonExistentDirectory_CreatesDirectoryAndWritesToFileto verify the directory is created and the file is written when intermediate directories are missing.# Previously failed if ./artifacts/licenses/ didn't exist nuget-license -i MyProject.csproj -o JsonPretty -fo ./artifacts/licenses/licenses.json