start migrating NuGetLicense.Test to tunit by sensslen · Pull Request #500 · sensslen/nuget-license

sensslen · 2026-04-03T21:10:28Z

No description provided.

coderabbitai · 2026-04-03T21:10:35Z

Important

Review skipped

Too many files!

This PR contains 217 files, which is 67 over the limit of 150.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ec384dfa-4424-458b-b6ed-23c8c66eb03a

📥 Commits

Reviewing files that changed from the base of the PR and between e108a16 and 588eefd.

📒 Files selected for processing (217)

.editorconfig
.github/workflows/action.yml
.github/workflows/assets/App/allowedLicenses.json
.github/workflows/assets/App/ignorePackages.json
.github/workflows/assets/App/overwritePackageInformation.json
.github/workflows/assets/App/projectsToCheck.json
.github/workflows/assets/App/urlToLicenseMapping.json
.github/workflows/assets/Licenses/MSTestingLicense.txt
.github/workflows/assets/Licenses/SonarSourceAvailable.txt
.github/workflows/assets/ProjectWithReferenceContainingFileLicense/allowedLicenses.json
.github/workflows/assets/ProjectWithReferenceContainingFileLicense/ignorePackages.json
.github/workflows/assets/ProjectWithReferenceContainingFileLicense/overwritePackageInformation.json
.github/workflows/assets/ProjectWithReferenceContainingFileLicense/projectsToCheck.json
.github/workflows/assets/ProjectWithReferenceContainingFileLicense/urlToLicenseMapping.json
.github/workflows/assets/ProjectWithReferenceContainingLicenseExpression/allowedLicenses.json
.github/workflows/assets/ProjectWithReferenceContainingLicenseExpression/ignorePackages.json
.github/workflows/assets/ProjectWithReferenceContainingLicenseExpression/overwritePackageInformation.json
.github/workflows/assets/ProjectWithReferenceContainingLicenseExpression/projectsToCheck.json
.github/workflows/assets/ProjectWithReferenceContainingLicenseExpression/urlToLicenseMapping.json
.github/workflows/assets/ProjectWithReferenceContainingWindowsSpecificPath/allowedLicenses.json
.github/workflows/assets/ProjectWithReferenceContainingWindowsSpecificPath/fileToLicenseMapping.json
.github/workflows/assets/ProjectWithReferenceContainingWindowsSpecificPath/ignorePackages.json
.github/workflows/assets/ProjectWithReferenceContainingWindowsSpecificPath/overwritePackageInformation.json
.github/workflows/assets/ProjectWithReferenceContainingWindowsSpecificPath/projectsToCheck.json
.github/workflows/assets/ProjectWithReferenceContainingWindowsSpecificPath/urlToLicenseMapping.json
.github/workflows/assets/Sln/allowedLicenses.json
.github/workflows/assets/Sln/fileToLicenseMapping.json
.github/workflows/assets/Sln/ignorePackages.json
.github/workflows/assets/Sln/overwritePackageInformation.json
.github/workflows/assets/Sln/projectsToCheck.json
.github/workflows/assets/Sln/urlToLicenseMapping.json
.github/workflows/assets/Slnx/allowedLicenses.json
.github/workflows/assets/Slnx/fileToLicenseMapping.json
.github/workflows/assets/Slnx/ignorePackages.json
.github/workflows/assets/Slnx/overwritePackageInformation.json
.github/workflows/assets/Slnx/projectsToCheck.json
.github/workflows/assets/Slnx/urlToLicenseMapping.json
.github/workflows/assets/Tests/allowedLicenses.json
.github/workflows/assets/Tests/fileToLicenseMapping.json
.github/workflows/assets/Tests/ignorePackages.json
.github/workflows/assets/Tests/overwritePackageInformation.json
.github/workflows/assets/Tests/projectsToCheck.json
.github/workflows/assets/Tests/urlToLicenseMapping.json
.github/workflows/release.yml
NuGetUtility.sln
NuGetUtility.slnx
src/FileLicenseMatcher/Combine/LicenseMatcher.cs
src/FileLicenseMatcher/Compare/LicenseMatcher.cs
src/FileLicenseMatcher/IFileLicenseMatcher.cs
src/FileLicenseMatcher/SPDX/FastLicenseMatcher.cs
src/FileLicenseMatcher/SPDX/JavaCore/ILicenseTemplateOutputHandler.cs
src/FileLicenseMatcher/SPDX/JavaCore/InvalidSPDXAnalysisException.cs
src/FileLicenseMatcher/SPDX/JavaCore/LicenseParserException.cs
src/FileLicenseMatcher/SPDX/JavaCore/LicenseTemplateRule.cs
src/FileLicenseMatcher/SPDX/JavaCore/LicenseTemplateRuleException.cs
src/FileLicenseMatcher/SPDX/JavaCore/LicenseTextHelper.cs
src/FileLicenseMatcher/SPDX/JavaCore/LineColumn.cs
src/FileLicenseMatcher/SPDX/JavaCore/SpdxLicenseTemplateHelper.cs
src/FileLicenseMatcher/SPDX/JavaLibrary/CompareTemplateOutputHandler.cs
src/FileLicenseMatcher/SPDX/JavaLibrary/DifferenceDescription.cs
src/FileLicenseMatcher/SPDX/JavaLibrary/LicenseCompareHelper.cs
src/FileLicenseMatcher/SPDX/JavaLibrary/ParseInstruction.cs
src/FileLicenseMatcher/SPDX/JavaLibrary/SpdxCompareException.cs
src/NuGetLicense/CommandLineOptionsParser.cs
src/NuGetLicense/ICommandLineOptions.cs
src/NuGetLicense/ICommandLineOptionsParser.cs
src/NuGetLicense/ILicenseValidationOrchestrator.cs
src/NuGetLicense/LicenseValidationOrchestrator.cs
src/NuGetLicense/LicenseValidator/LicenseDownloadException.cs
src/NuGetLicense/LicenseValidator/LicenseExpressions.cs
src/NuGetLicense/LicenseValidator/LicenseInformationOrigin.cs
src/NuGetLicense/LicenseValidator/LicenseValidationResult.cs
src/NuGetLicense/LicenseValidator/LicenseValidator.cs
src/NuGetLicense/LicenseValidator/UrlToLicenseMapping.cs
src/NuGetLicense/LicenseValidator/ValidationError.cs
src/NuGetLicense/Output/Csv/CsvOutputFormatter.cs
src/NuGetLicense/Output/IOutputFormatter.cs
src/NuGetLicense/Output/Json/JsonOutputFormatter.cs
src/NuGetLicense/Output/Table/TableOutputFormatter.cs
src/NuGetLicense/Program.cs
src/NuGetLicense/Serialization/ValidatedLicenseJsonConverterWithOmittingEmptyErrorList.cs
src/NuGetLicenseCore/Program.cs
src/NuGetLicenseFramework/Program.cs
src/NuGetUtility/AppLifetime.cs
src/NuGetUtility/Extensions/AsyncEnumerableExtension.cs
src/NuGetUtility/Extensions/HashSetExtension.cs
src/NuGetUtility/Extensions/ProjectExtensions.cs
src/NuGetUtility/Extensions/StringExtensions.cs
src/NuGetUtility/Extensions/TaskExtensions.cs
src/NuGetUtility/Output/Table/TablePrinter.cs
src/NuGetUtility/Output/Table/TablePrinterExtensions.cs
src/NuGetUtility/OutputType.cs
src/NuGetUtility/PackageInformationReader/CustomPackageInformation.cs
src/NuGetUtility/PackageInformationReader/PackageInformationReader.cs
src/NuGetUtility/PackageInformationReader/PackageMetadata.cs
src/NuGetUtility/PackageInformationReader/ProjectWithReferencedPackages.cs
src/NuGetUtility/PackageInformationReader/ReferencedPackageWithContext.cs
src/NuGetUtility/ProjectFiltering/ProjectFilter.cs
src/NuGetUtility/ReferencedPackagesReader/ProjectsCollector.cs
src/NuGetUtility/ReferencedPackagesReader/ReferencedPackageReader.cs
src/NuGetUtility/ReferencedPackagesReader/ReferencedPackageReaderException.cs
src/NuGetUtility/Serialization/NuGetVersionJsonConverter.cs
src/NuGetUtility/Serialization/UriDictionaryJsonConverter.cs
src/NuGetUtility/Wrapper/HttpClientWrapper/DownloadFailedException.cs
src/NuGetUtility/Wrapper/HttpClientWrapper/FileDownloader.cs
src/NuGetUtility/Wrapper/HttpClientWrapper/IFileDownloader.cs
src/NuGetUtility/Wrapper/HttpClientWrapper/NopFileDownloader.cs
src/NuGetUtility/Wrapper/MsBuildWrapper/IMsBuildAbstraction.cs
src/NuGetUtility/Wrapper/MsBuildWrapper/IProject.cs
src/NuGetUtility/Wrapper/MsBuildWrapper/MsBuildAbstraction.cs
src/NuGetUtility/Wrapper/MsBuildWrapper/MsBuildAbstractionException.cs
src/NuGetUtility/Wrapper/MsBuildWrapper/PackageReference.cs
src/NuGetUtility/Wrapper/MsBuildWrapper/PackageReferenceMetadata.cs
src/NuGetUtility/Wrapper/MsBuildWrapper/ProjectWrapper.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Frameworks/INuGetFramework.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Frameworks/INuGetFrameworkUtility.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Frameworks/NuGetFrameworkUtility.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Frameworks/WrappedNuGetFramework.cs
src/NuGetUtility/Wrapper/NuGetWrapper/NugetWrapperException.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Packaging/Core/FailingPackagesConfigReader.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Packaging/Core/IPackageDependency.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Packaging/Core/IPackagesConfigReader.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Packaging/Core/PackageIdentity.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Packaging/Core/PackagesConfigReaderException.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Packaging/Core/WindowsPackagesConfigReader.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Packaging/Core/WrappedPackageDependency.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Packaging/IPackageMetadata.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Packaging/LicenseMetadata.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Packaging/LicenseType.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/AssetsPackageDependencyReader.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/IAssetsPackageDependencyReader.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/ILibraryDependency.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/ILockFile.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/ILockFileFactory.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/ILockFileLibrary.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/ILockFileTarget.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/ILockFileTargetLibrary.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/IPackageSpec.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/ITargetFrameworkInformation.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/LockFileFactory.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/WrappedLibraryDependency.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/WrappedLockFile.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/WrappedLockFileLibrary.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/WrappedLockFileTarget.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/WrappedLockFileTargetLibrary.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/WrappedPackageSpec.cs
src/NuGetUtility/Wrapper/NuGetWrapper/ProjectModel/WrappedTargetFrameworkInformation.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/Core/Types/CachingDisposableSourceRepository.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/Core/Types/CachingFindPackageByIdResource.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/Core/Types/CachingPackageMetadataResource.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/Core/Types/IDisposableSourceRepository.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/Core/Types/IFindPackageByIdResource.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/Core/Types/IPackageDownloader.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/Core/Types/IPackageMetadataResource.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/Core/Types/ISourceRepository.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/Core/Types/IWrappedSourceRepositoryProvider.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/Core/Types/WrappedPackageDownloader.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/Core/Types/WrappedSourceRepositoryProvider.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/GlobalPackagesFolderUtility.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/IGlobalPackagesFolderUtility.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/LicenseAugmentedPackageMetadata.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Protocol/WrappedPackageMetadata.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Versioning/INuGetVersion.cs
src/NuGetUtility/Wrapper/NuGetWrapper/Versioning/WrappedNuGetVersion.cs
src/NuGetUtility/Wrapper/SolutionPersistenceWrapper/ISolutionPersistanceWrapper.cs
src/NuGetUtility/Wrapper/SolutionPersistenceWrapper/SolutionPersistanceException.cs
src/NuGetUtility/Wrapper/SolutionPersistenceWrapper/SolutionPersistanceWrapper.cs
tests/FileLicenseMatcher.Test/Combine/LicenseMatcherTest.cs
tests/FileLicenseMatcher.Test/Compare/LicenseMatcherTest.cs
tests/FileLicenseMatcher.Test/FileLicenseMatcher.Test.csproj
tests/FileLicenseMatcher.Test/SPDX/LicenseMatcherTest.cs
tests/NuGetLicense.Test/CommandLineOptionsParserTest.cs
tests/NuGetLicense.Test/LicenseValidationOrchestratorTest.cs
tests/NuGetLicense.Test/LicenseValidator/LicenseValidationResultValueEqualityComparer.cs
tests/NuGetLicense.Test/LicenseValidator/LicenseValidatorTest.cs
tests/NuGetLicense.Test/NuGetLicense.Test.csproj
tests/NuGetLicense.Test/Output/Csv/CsvOutputFormatterSpecialCases.cs
tests/NuGetLicense.Test/Output/Csv/CsvOutputFormatterTests.cs
tests/NuGetLicense.Test/Output/Helper/NuGetVersion.cs
tests/NuGetLicense.Test/Output/Json/JsonOutputFormatterTest.cs
tests/NuGetLicense.Test/Output/Table/MarkdownTableOutputFormatterTest.cs
tests/NuGetLicense.Test/Output/Table/TableOutputFormatterTest.cs
tests/NuGetLicense.Test/Output/TestBase.cs
tests/NuGetUtility.Test.Extensions/AutoFixtureExtensions.cs
tests/NuGetUtility.Test.Extensions/Helper/AsyncEnumerableExtension/AsyncEnumerable.cs
tests/NuGetUtility.Test.Extensions/Helper/AsyncEnumerableExtension/AsyncEnumerableExtension.cs
tests/NuGetUtility.Test.Extensions/Helper/AsyncEnumerableExtension/AsyncEnumerator.cs
tests/NuGetUtility.Test.Extensions/Helper/AutoFixture/NuGet/Versioning/CustomPackageInformationBuilderWithOptionalFileds.cs
tests/NuGetUtility.Test.Extensions/Helper/AutoFixture/NuGet/Versioning/ExtendedAutoDataAttribute.cs
tests/NuGetUtility.Test.Extensions/Helper/AutoFixture/NuGet/Versioning/ExtendedInlineAutoDataAttribute.cs
tests/NuGetUtility.Test.Extensions/Helper/AutoFixture/NuGet/Versioning/NuGetVersionBuilder.cs
tests/NuGetUtility.Test.Extensions/Helper/NUnitExtension/EnumEnumerableWithException.cs
tests/NuGetUtility.Test.Extensions/Helper/NUnitExtension/EnumEnumeratorWithExceptions.cs
tests/NuGetUtility.Test.Extensions/Helper/NUnitExtension/EnumValuesExceptAttribute.cs
tests/NuGetUtility.Test.Extensions/Helper/ShuffelledEnumerable/EnumerableExtensions.cs
tests/NuGetUtility.Test.Extensions/Helper/Type/TypeExtensions.cs
tests/NuGetUtility.Test.Extensions/MemoryStreamExtension.cs
tests/NuGetUtility.Test.Extensions/NuGetUtility.Test.Extensions.csproj
tests/NuGetUtility.Test/Architecture/ArchitectureTest.cs
tests/NuGetUtility.Test/Architecture/ConditionsExtensions.cs
tests/NuGetUtility.Test/Architecture/Rules/NugetAbstractionTest.cs
tests/NuGetUtility.Test/Extensions/HashSetExtensionTestObject.cs
tests/NuGetUtility.Test/Extensions/HashSetExtensionsTest.cs
tests/NuGetUtility.Test/Extensions/ProjectExtensionsTest.cs
tests/NuGetUtility.Test/Extensions/StringExtensionsTest.cs
tests/NuGetUtility.Test/NuGetUtility.Test.csproj
tests/NuGetUtility.Test/PackageInformationReader/PackageInformationReaderTest.cs
tests/NuGetUtility.Test/ProjectFiltering/ProjectFiltererTest.cs
tests/NuGetUtility.Test/ReferencedPackagesReader/ProjectsCollectorTest.cs
tests/NuGetUtility.Test/ReferencedPackagesReader/ReferencedPackageReaderTest.cs
tests/NuGetUtility.Test/ReferencedPackagesReader/ReferencedPackagesReaderIntegrationTest.cs
tests/NuGetUtility.UrlToLicenseMapping.Test/NuGetUtility.UrlToLicenseMapping.Test.csproj
tests/NuGetUtility.UrlToLicenseMapping.Test/Result.cs
tests/NuGetUtility.UrlToLicenseMapping.Test/UrlToLicenseMappingTest.cs
tests/targets/MultiTargetProjectWithDifferentDependencies/MultiTargetProjectWithDifferentDependencies.csproj
tests/targets/PackageReferenceProject/PackageReferenceProject.csproj
tests/targets/PackagesConfigProject/Properties/AssemblyInfo.cs

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch simon/update-to-tunit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sonarqubecloud · 2026-04-07T23:58:41Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sensslen force-pushed the simon/update-to-tunit branch 6 times, most recently from 12adfcc to 47a3167 Compare April 7, 2026 19:20

sensslen added 5 commits April 7, 2026 21:37

start migrating NuGetLicense.Test to tunit

cee430a

try fixing build - use slnx to do so

b753524

fix sln/slnx ambiguity

0cb9028

Add more tests

cf0b1fb

remove explicit target platforms

bd57c94

sensslen force-pushed the simon/update-to-tunit branch from eefc93f to bd57c94 Compare April 7, 2026 19:38

correct license files and update some nuget packages

eb3fbc8

sensslen force-pushed the simon/update-to-tunit branch from e06469b to eb3fbc8 Compare April 7, 2026 20:07

sensslen added 11 commits April 7, 2026 22:18

fix old tests

ca93768

Fix re-entrancy in SpdxExpressionParser

c35a93a

Convert all tests over to tunit

4130246

add necessary overwrites

449bebc

fix sonarSourceAvailable license mapping

51d4bc0

keep output

9a0aab9

add proper license mapping to Tests project

9e32b6b

revert overrides - they are needed

66952df

attempt to fix build

62f2002

fix allowed licenses

8f5d466

more fixes

48ab223

sensslen force-pushed the simon/update-to-tunit branch from 5e843c6 to 48ab223 Compare April 7, 2026 23:39

sensslen added 2 commits April 8, 2026 01:45

next attempt to fix build

6021390

run tests directly

588eefd

sensslen marked this pull request as ready for review April 8, 2026 00:19

sensslen merged commit c83a39a into main Apr 8, 2026
44 checks passed

sensslen deleted the simon/update-to-tunit branch April 8, 2026 00:20

dependabot Bot mentioned this pull request May 14, 2026

Bump the nuget-minor-patch group with 4 updates st0o0/Signal.Bot#86

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

start migrating NuGetLicense.Test to tunit#500

start migrating NuGetLicense.Test to tunit#500
sensslen merged 19 commits into
mainfrom
simon/update-to-tunit

sensslen commented Apr 3, 2026

Uh oh!

coderabbitai Bot commented Apr 3, 2026 •

edited

Loading

Review skipped

Uh oh!

sonarqubecloud Bot commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sensslen commented Apr 3, 2026

Uh oh!

coderabbitai Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

sonarqubecloud Bot commented Apr 7, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Apr 3, 2026 •

edited

Loading